Skip to content

Commit d58bddf

Browse files
committed
Clean up stale IGR integration comments
1 parent 46c2212 commit d58bddf

3 files changed

Lines changed: 4 additions & 18 deletions

File tree

src/simulation/m_rhs.fpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,7 @@ contains
520520
$:END_GPU_PARALLEL_LOOP()
521521
end if
522522
523-
! TODO: Native IGR reconstruction still reads conservative ghost cells directly.
523+
! IGR reconstruction still reads conservative ghost-cell data directly.
524524
if (igr) then
525525
call nvtxStartRange("RHS-COMMUNICATION")
526526
call s_populate_variables_buffers(bc_type, q_cons_vf, pb_in, mv_in, q_T_sf)
@@ -548,7 +548,7 @@ contains
548548
if (qbmm) call s_mom_inv(q_cons_qp%vf, q_prim_qp%vf, mom_sp, mom_3d, pb_in, rhs_pb, mv_in, rhs_mv, idwbuff(1), &
549549
& idwbuff(2), idwbuff(3))
550550
551-
! TODO: IGR viscous terms are still evaluated by legacy IGR logic.
551+
! IGR fills its viscous source fluxes during custom reconstruction.
552552
if ((viscous .and. .not. igr)) then
553553
call nvtxStartRange("RHS-VISCOUS")
554554
call s_get_viscous(qL_rsx_vf, dqL_prim_dx_n, dqL_prim_dy_n, dqL_prim_dz_n, qL_prim, qR_rsx_vf, dqR_prim_dx_n, &

src/simulation/m_start_up.fpp

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -827,12 +827,10 @@ contains
827827
call s_initialize_acoustic_src()
828828
end if
829829

830-
! TODO: first igr divergence point
831830
if (viscous .and. (.not. igr)) then
832831
call s_initialize_viscous_module()
833832
end if
834833

835-
! TODO: second igr divergence point (inside module)
836834
call s_initialize_rhs_module()
837835

838836
if (surface_tension) call s_initialize_surface_tension_module()
@@ -843,7 +841,6 @@ contains
843841
call s_initialize_derived_variables_module()
844842
call s_initialize_time_steppers_module()
845843

846-
! TODO: may need to alter for igr integration
847844
call s_initialize_boundary_common_module()
848845

849846
if (down_sample) then
@@ -906,15 +903,10 @@ contains
906903

907904
! Computation of parameters, allocation of memory, association of pointers, and/or execution of any other tasks that are
908905
! needed to properly configure the modules. The preparations below DO DEPEND on the grid being complete.
909-
! TODO: main igr divergence point
910906
if (igr) then
911907
call s_initialize_igr_module()
912-
! initialize riemann solvers module for inviscid igr branch
913908
call s_initialize_riemann_solvers_module()
914909
end if
915-
! non-igr implementation uses WENO, MUSCL reconstruction modules and riemann solvers module
916-
! goal is to initialize these modules alongside igr and make igr a flux modifier
917-
! To be determined
918910
if (.not. igr) then
919911
if (recon_type == recon_type_weno) then
920912
call s_initialize_weno_module()
@@ -1070,7 +1062,6 @@ contains
10701062
if (ib) then
10711063
$:GPU_UPDATE(device='[ib_markers%sf]')
10721064
end if
1073-
! TODO: may need to copy data for igr integration
10741065
#:if not MFC_CASE_OPTIMIZATION
10751066
$:GPU_UPDATE(device='[igr, nb, igr_order]')
10761067
#:endif
@@ -1085,12 +1076,9 @@ contains
10851076
if (hyperelasticity) call s_finalize_hyperelastic_module()
10861077
call s_finalize_derived_variables_module()
10871078
call s_finalize_data_output_module()
1088-
! TODO: potential igr divergence point
10891079
call s_finalize_rhs_module()
1090-
! TODO: igr divergence point, the same way they diverged in s_initialize_modules
10911080
if (igr) then
10921081
call s_finalize_igr_module()
1093-
! finalize riemann solvers module for inviscid igr branch
10941082
call s_finalize_riemann_solvers_module()
10951083
else
10961084
call s_finalize_cbc_module()
@@ -1109,7 +1097,6 @@ contains
11091097
call s_finalize_boundary_common_module()
11101098
if (relax) call s_finalize_relaxation_solver_module()
11111099
if (bubbles_lagrange) call s_finalize_lagrangian_solver()
1112-
! TODO: igr divergence point, mirroring s_initialize_modules
11131100
if (viscous .and. (.not. igr)) then
11141101
call s_finalize_viscous_module()
11151102
end if

src/simulation/m_time_steppers.fpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ contains
462462

463463
if (s == 1) then
464464
if (run_time_info) then
465-
! TODO: route IGR runtime information through q_prim_vf once primitive workspace semantics are fully integrated.
465+
! IGR runtime information still uses conservative variables until primitive workspaces are fully integrated
466466
if (igr) then
467467
call s_write_run_time_information(q_cons_ts(1)%vf, t_step)
468468
end if
@@ -625,8 +625,7 @@ contains
625625
integer :: j, k, l !< Generic loop iterators
626626
integer :: fl !< Fluid loop iterator
627627

628-
! TODO: use the normal primitive workspace for IGR dt calculation once
629-
! q_prim_vf is authoritative for IGR diagnostics and stability checks.
628+
! IGR dt calculation still uses its custom conservative-variable path.
630629
if (.not. igr) then
631630
call s_convert_conservative_to_primitive_variables(q_cons_ts(1)%vf, q_T_sf, q_prim_vf, idwint)
632631
end if

0 commit comments

Comments
 (0)