codegen: broadcast the Herschel-Bulkley fluid_pp members

The hardcoded fluid_pp emitter predated the #1545 merge and silently dropped K/nn/tau0/hb_m/mu_min/mu_max/mu_bulk and non_newtonian from the generated lists - a multi-rank regression for non-Newtonian runs relative to the manual lists it replaced. Emitted sets now verified member-identical to master's manual lists per target. Caught by automated PR review.

Author: sbryngelson

toolchain/mfc/params/generators/fortran_gen.py

@@ -318,16 +318,16 @@ def _emit_bcast_group(lines: List[str], vars_list: List[str], mpi_type: str) ->
 def _emit_fluid_pp(lines: List[str], target: str) -> None:
     """Emit the fluid_pp(i) member-loop broadcast block.
 
-    Members broadcast: gamma, pi_inf, G, cv, qv, qvp (all REAL, mpi_p).
-    Sim additionally: Re(1) with count=2.
+    Members broadcast: the 13 REAL members (EOS core plus the Herschel-Bulkley
+    non-Newtonian set) and the LOGICAL non_newtonian flag, matching the manual
+    lists this generator replaces. Sim additionally: Re(1) with count=2.
     """
-    # These are the core EOS members broadcast in all three targets.
-    # Other fluid_pp members in the registry (mu_v, pv, mul0, ss, D_v, etc.) are
-    # physics-specific and are initialised from input on rank 0 only or derived.
-    fp_real_members = ["gamma", "pi_inf", "G", "cv", "qv", "qvp"]
+    fp_real_members = ["gamma", "pi_inf", "G", "cv", "qv", "qvp",
+                       "K", "nn", "tau0", "hb_m", "mu_min", "mu_max", "mu_bulk"]
     lines.append("        do i = 1, num_fluids_max")
     for mem in fp_real_members:
         lines.append(f"            call MPI_BCAST(fluid_pp(i)%{mem}, 1, mpi_p, 0, MPI_COMM_WORLD, ierr)")
+    lines.append("            call MPI_BCAST(fluid_pp(i)%non_newtonian, 1, MPI_LOGICAL, 0, MPI_COMM_WORLD, ierr)")
     if target == "sim":
         lines.append("            call MPI_BCAST(fluid_pp(i)%Re(1), 2, mpi_p, 0, MPI_COMM_WORLD, ierr)")
     lines.append("        end do")

toolchain/mfc/params_tests/test_fortran_gen.py

@@ -414,6 +414,10 @@ def test_generate_bcast_fpp_fluid_pp_loop():
         assert "do i = 1, num_fluids_max" in out, f"{target}: fluid_pp loop missing"
         assert "call MPI_BCAST(fluid_pp(i)%gamma, 1, mpi_p, 0, MPI_COMM_WORLD, ierr)" in out
         assert "call MPI_BCAST(fluid_pp(i)%cv, 1, mpi_p, 0, MPI_COMM_WORLD, ierr)" in out
+        # Herschel-Bulkley members (#1545) — dropping any is a multi-rank regression
+        for hb in ("K", "nn", "tau0", "hb_m", "mu_min", "mu_max", "mu_bulk"):
+            assert f"call MPI_BCAST(fluid_pp(i)%{hb}, 1, mpi_p, 0, MPI_COMM_WORLD, ierr)" in out, f"missing HB member {hb}"
+        assert "call MPI_BCAST(fluid_pp(i)%non_newtonian, 1, MPI_LOGICAL, 0, MPI_COMM_WORLD, ierr)" in out
 
     sim = generate_bcast_fpp("sim")
     assert "call MPI_BCAST(fluid_pp(i)%Re(1), 2, mpi_p, 0, MPI_COMM_WORLD, ierr)" in sim