Skip to content

Commit e686654

Browse files
sbryngelsonclaude
andcommitted
ci: remove redundant slurm_job_id write, improve bench log output
- run_monitored_slurm_job.sh: remove redundant .slurm_job_id write; submit-job.sh already writes it before the monitor is called, so the second write was a no-op in all code paths - bench.yml: replace two separate per-case log steps with one organized step: prints a summary table (N failed, N passed) with all case names first, then full logs only for failed cases — passing runs stay concise Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 0a39803 commit e686654

2 files changed

Lines changed: 16 additions & 11 deletions

File tree

.github/scripts/run_monitored_slurm_job.sh

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,6 @@ output_file="$2"
1818

1919
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
2020

21-
# Write job ID next to the output file so the workflow cancel step can scancel it
22-
# if GitHub Actions terminates the runner (SIGKILL cannot be caught by trap).
23-
echo "$job_id" > "${output_file%.out}.slurm_job_id"
24-
2521
monitor_exit=0
2622
bash "$SCRIPT_DIR/monitor_slurm_job.sh" "$job_id" "$output_file" || monitor_exit=$?
2723

.github/workflows/bench.yml

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -148,17 +148,26 @@ jobs:
148148
- name: Print Per-Case Logs
149149
if: always()
150150
run: |
151+
passed=() failed=()
151152
for out in pr/build/benchmarks/*/*.out master/build/benchmarks/*/*.out; do
152153
[ -f "$out" ] || continue
153-
yaml="${out%.out}.yaml"
154-
if [ -f "$yaml" ]; then
155-
echo "=== [PASSED] $out ==="
156-
else
157-
echo "=== [FAILED] $out ==="
158-
fi
159-
cat "$out"
154+
[ -f "${out%.out}.yaml" ] && passed+=("$out") || failed+=("$out")
160155
done
161156
157+
echo "=== Per-Case Summary: ${#failed[@]} failed, ${#passed[@]} passed ==="
158+
for out in "${failed[@]}"; do echo " [FAILED] $out"; done
159+
for out in "${passed[@]}"; do echo " [PASSED] $out"; done
160+
161+
if [ ${#failed[@]} -gt 0 ]; then
162+
echo ""
163+
echo "=== Failed Case Logs ==="
164+
for out in "${failed[@]}"; do
165+
echo "--- $out ---"
166+
cat "$out"
167+
echo ""
168+
done
169+
fi
170+
162171
# All other runners (non-Phoenix) just run without special env
163172
- name: Archive Logs (Frontier)
164173
if: always() && matrix.cluster != 'phoenix'

0 commit comments

Comments
 (0)