Skip to content

Commit e71b8cc

Browse files
sbryngelsonclaude
andcommitted
Fix Phoenix test/bench scripts: preserve deps on retry, add --no-gpu for CPU
Same fixes previously applied to Frontier scripts but missed for Phoenix: - Use targeted clean (-t) to avoid wiping pre-fetched deps on retry - Add --no-gpu for CPU test jobs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 7179e09 commit e71b8cc

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

.github/workflows/phoenix/bench.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ while [ $attempt -le $max_attempts ]; do
4848
fi
4949

5050
if [ $attempt -lt $max_attempts ]; then
51-
echo "Build failed on attempt $attempt. Cleaning and retrying in 30s..."
52-
./mfc.sh clean
51+
echo "Build failed on attempt $attempt. Cleaning source targets and retrying in 30s..."
52+
./mfc.sh clean -t pre_process simulation post_process syscheck
5353
sleep 30
5454
else
5555
echo "Build failed after $max_attempts attempts."

.github/workflows/phoenix/test.sh

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ if [ "$job_device" = "gpu" ]; then
1010
fi
1111
fi
1212

13+
# Build source code on compute node (deps already fetched on login node)
1314
max_attempts=3
1415
attempt=1
1516
while [ $attempt -le $max_attempts ]; do
@@ -20,8 +21,8 @@ while [ $attempt -le $max_attempts ]; do
2021
fi
2122

2223
if [ $attempt -lt $max_attempts ]; then
23-
echo "Build failed on attempt $attempt. Cleaning and retrying in 30s..."
24-
./mfc.sh clean
24+
echo "Build failed on attempt $attempt. Cleaning source targets and retrying in 30s..."
25+
./mfc.sh clean -t pre_process simulation post_process syscheck
2526
sleep 30
2627
else
2728
echo "Build failed after $max_attempts attempts."
@@ -37,6 +38,8 @@ if [ "$job_device" = "gpu" ]; then
3738
gpu_ids=$(seq -s ' ' 0 $(($gpu_count-1))) # 0,1,2,...,gpu_count-1
3839
device_opts="-g $gpu_ids"
3940
n_test_threads=`expr $gpu_count \* 2`
41+
else
42+
device_opts="--no-gpu"
4043
fi
4144

4245
./mfc.sh test -v --max-attempts 3 -a -j $n_test_threads $device_opts -- -c phoenix

0 commit comments

Comments
 (0)