toolchain: validate patch_ib against the namelist array bound; refresh dedup docs

NIB read num_ib_patches_max (2050000) but the patch_ib namelist array is dimensioned num_ib_patches_max_namelist (54000), so validation accepted indices that overflow the array. Also refreshes three doc passages made stale by the dedup. Both flagged by review.

Author: sbryngelson

.claude/rules/common-pitfalls.md

@@ -14,7 +14,7 @@ covered in `docs/documentation/contributing.md`.
   bubbles and IB. Read that routine for the current value rather than assuming one.
 - Riemann solvers: left state at `j`, right state at `j+1`.
 - All equation indices live in the `eqn_idx` struct (`eqn_idx_info` in
-  `m_derived_types.fpp`, populated in `m_global_parameters.fpp`): `%cont`, `%mom`, `%E`,
+  `m_derived_types.fpp`, populated by `s_initialize_eqn_idx` in `m_global_parameters_common.fpp`): `%cont`, `%mom`, `%E`,
   `%adv`, plus optional ranges (`%bub`, `%stress`, `%species`, `%B`, ...). The old
   `contxb`/`momxb` shorthands are gone. Index positions depend on `model_eqns` and
   enabled features — changing either moves ALL indices; never hard-code one.
@@ -66,7 +66,7 @@ covered in `docs/documentation/contributing.md`.
   `use m_global_parameters` continues to work for all downstream modules without change.
   Sim-only declarations (GPU_DECLARE, Re_idx allocation) stay in
   `m_global_parameters_common` behind `#ifdef MFC_SIMULATION`. Generated includes
-  (`generated_decls.fpp`, `generated_bcast.fpp`) must exist for every target — the build
+  (`generated_decls.fpp`, `generated_bcast.fpp`, `generated_case_opt_decls.fpp`) must exist for every target — the build
   emits stubs where the content is sim-only, so a common file that includes one will
   compile for pre/post too.
 - Runtime checks (`@:PROHIBIT`) go where they run: shared →

docs/documentation/contributing.md

@@ -319,7 +319,7 @@ Scalar declarations, GPU declare lines, Doxygen descriptions, and namelist bindi
 auto-generated at build time (ninja-tracked custom command) from the `TYPED_DECLS` and `FORTRAN_ARRAY_DIMS`
 tables in `toolchain/mfc/params/definitions.py`. For a plain scalar registered with
 `_r()` / `_nv()` above, no manual Fortran edit is needed — reconfigure (`./mfc.sh build`)
-and the generated include in each target's `m_global_parameters.fpp` is updated
+and the generated include in `m_global_parameters_common.fpp` (compiled per target) is updated
 automatically.
 
 Still manual (not auto-generated):

toolchain/mfc/params/definitions.py

@@ -31,7 +31,7 @@ def _fc(name: str, default: int) -> int:
 NPR = _fc("num_probes_max", 10)  # probe, acoustic, integral
 NB = _fc("num_bc_patches_max", 10)  # patch_bc
 NUM_PATCHES_MAX = _fc("num_patches_max", 10)  # patch_icpp (Fortran array bound)
-NIB = _fc("num_ib_patches_max", 54000)  # patch_ib (Fortran array bound)
+NIB = _fc("num_ib_patches_max_namelist", 54000)  # patch_ib namelist array bound
 NAF = _fc("num_ib_airfoils_max", 5)  # ib_airfoil (Fortran array bound)
 NSM = _fc("num_stl_models_max", 10)  # stl_models (Fortran array bound)
 NPB = _fc("num_particle_clouds_max", 10)  # particle_cloud (Fortran array bound)