Address AI reviewer feedback: fix configs, harden lint_docs, add Python 3.10+ guidance

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: sbryngelson

.coderabbit.yaml

@@ -1,5 +1,5 @@
 # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
-language: en-us
+language: en-US
 
 reviews:
   profile: chill
@@ -15,7 +15,8 @@ reviews:
         docs/documentation/contributing.md.
     - path: "toolchain/**/*.py"
       instructions: |
-        Python toolchain code. Follow PEP 8.
+        Python toolchain code. Follow PEP 8. Requires Python 3.10+;
+        do not suggest __future__ imports or backwards-compatibility shims.
 
 knowledge_base:
   code_guidelines:

.github/CONTRIBUTING.md

@@ -2,7 +2,7 @@
 
 We welcome contributions of all kinds -- bug fixes, new features, documentation, tests, and issue triage.
 
-**Full developer guide:** [mflowcode.github.io/documentation/md_contributing.html](https://mflowcode.github.io/documentation/contributing.html)
+**Full developer guide:** [mflowcode.github.io/documentation/contributing.html](https://mflowcode.github.io/documentation/contributing.html)
 
 ## Quick Reference
 

.github/copilot-instructions.md

@@ -19,6 +19,7 @@ Formatting and linting are enforced by pre-commit hooks. Focus review effort on
 * Only `simulation` (plus its `common` dependencies) is GPU-accelerated via **OpenACC**.
 * Code must compile with **GNU gfortran**, **NVIDIA nvfortran**, **Cray ftn**, and **Intel ifx**.
 * Precision modes: double (default), single, and mixed (`wp` = working precision, `stp` = storage precision).
+* **Python toolchain** requires **Python 3.10+** — do not suggest `from __future__` imports or other backwards-compatibility shims.
 
 ---
 

.pr_agent.toml

@@ -19,6 +19,8 @@ correctness (pack/unpack offsets, GPU data coherence), precision mixing
 consistency (pressure formula must match model_eqns), missing case_validator.py
 constraints for new parameters, and compiler portability across all four
 supported compilers.
+Python toolchain requires Python 3.10+; do not suggest __future__ imports
+or other backwards-compatibility shims.
 """
 
 [pr_code_suggestions]

toolchain/bootstrap/precheck.sh

@@ -132,6 +132,7 @@ log "[$CYAN 5/5$COLOR_RESET] Checking$MAGENTA doc references$COLOR_RESET..."
 if python3 toolchain/mfc/lint_docs.py 2>&1; then
     ok "Doc references are valid."
 else
+    error "Doc reference check failed. Run$MAGENTA python3 toolchain/mfc/lint_docs.py$COLOR_RESET for details."
     FAILED=1
 fi
 

toolchain/mfc/lint_docs.py

@@ -11,8 +11,6 @@
     "docs/documentation/running.md",
     "docs/documentation/case.md",
     ".github/copilot-instructions.md",
-    ".pr_agent.toml",
-    ".coderabbit.yaml",
 ]
 
 # Match backtick-wrapped strings that look like repo-relative file paths
@@ -28,7 +26,7 @@ def check_docs(repo_root: Path) -> list[str]:
         doc_path = repo_root / doc
         if not doc_path.exists():
             continue
-        text = doc_path.read_text()
+        text = doc_path.read_text(encoding="utf-8")
         for match in PATH_RE.finditer(text):
             path_str = match.group(1)
             if SKIP_RE.search(path_str):