Skip to content

Simplify execution of main.py by removing command checks #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbryngelson merged 3 commits into from
Feb 23, 2026
Merged

Simplify execution of main.py by removing command checks #1251

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d641c88
Simplify execution of main.py by removing command checks
sbryngelson Feb 22, 2026
d456066
Add command handling for main.py in mfc.sh
sbryngelson Feb 23, 2026
ee2ad3a
Update claude-code-review workflow configuration
sbryngelson Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions mfc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,20 +83,6 @@ fi

echo

# Run the main.py bootstrap script
# If only flags given (no command), show help without passing flags
has_command=false
for arg in "$@"; do
case "$arg" in -*) ;; *) has_command=true; break ;; esac
done
if [ "$has_command" = true ]; then
python3 "$(pwd)/toolchain/main.py" "$@"
else
python3 "$(pwd)/toolchain/main.py"
fi
code=$?

echo

if [ $code -ne 0 ]; then

Copilot AI Feb 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable $code is referenced but never set after the removal of the python3 execution block. This will cause the script to fail or behave unexpectedly. Either remove this conditional check or ensure $code is set by adding back the main.py execution with proper exit code capture.

Copilot uses AI. Check for mistakes.
error "main.py finished with a $code exit code."
Comment on lines 101 to 102

@codeant-ai codeant-ai Bot Feb 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Safely handle the exit status by defaulting to zero when it is unset and avoid unquoted numeric comparison. [custom_rule]

Severity Level: Minor ⚠️

Suggested change
if [ $code -ne 0 ]; then
error "main.py finished with a $code exit code."
if [ "${code:-0}" -ne 0 ]; then
error "main.py finished with a ${code:-0} exit code."
Why it matters? ⭐

The existing numeric test can fail with "integer expression expected" when $code is unset or empty; the improved code uses a safe default ("${code:-0}") and quotes the expansion so the test is robust. This directly fixes a correctness/robustness issue in the shell script (avoid unquoted/unset variable in numeric comparison), which is in line with the repository's emphasis on correctness over style.

Prompt for AI Agent 🤖 
This is a comment left during a code review.

**Path:** mfc.sh
**Line:** 87:88
**Comment:**
	*Custom Rule: Safely handle the exit status by defaulting to zero when it is unset and avoid unquoted numeric comparison.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
👍 | 👎

Expand Down
Loading