ci(coverage): guard health-check skip against empty exception message#1474
Merged
Merged
Conversation
If a skipped case raised an exception with an empty str() (e.g. ImportError() with no message), str(exc).strip().splitlines()[-1] indexed an empty list -> IndexError inside the except handler, which is uncaught and crashes the graceful-skip path. Fall back to '(no message)'. Caught by Claude Code Review on MFlowCode#1471.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1474 +/- ##
=======================================
Coverage 61.31% 61.31%
=======================================
Files 72 72
Lines 19771 19771
Branches 2852 2852
=======================================
Hits 12123 12123
Misses 5699 5699
Partials 1949 1949 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1471. Addresses a Claude Code Review finding: in the skip handler,
raises
IndexErrorif the exception's message is empty ("".splitlines()→[]), and that secondary error is inside theexcepthandler so it propagates and crashes the very graceful-skip path the change added. Low-probability (our cases raiseMFCExceptionwith messages) but a real latent crash.Fix:
(str(exc).strip().splitlines() or ["(no message)"])[-1][:140].Verified locally: still skips the 8 chemistry cases and reports healthy; the empty-
ImportError()case now yields'(no message)'instead of raising.