Fix: Adding missing @:DEALLOCATE's#1592
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1592 +/- ##
=======================================
Coverage 60.48% 60.48%
=======================================
Files 83 83
Lines 19888 19888
Branches 2951 2951
=======================================
Hits 12030 12030
Misses 5864 5864
Partials 1994 1994 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sbryngelson
approved these changes
Jun 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a one-shot memory leak (and associated GPU mapping leak) in the simulation Riemann solvers module by ensuring all module-allocated arrays are properly deallocated during finalization.
Changes:
- Added missing
@:DEALLOCATE(Res_gs)inside theviscousfinalization path. - Added missing
@:DEALLOCATE(Gs_rs)during module finalization.
sbryngelson
added a commit
to SVS87/MFC
that referenced
this pull request
Jun 24, 2026
fahnab666
pushed a commit
to fahnab666/mfc-nabid
that referenced
this pull request
Jul 6, 2026
Co-authored-by: Joshua Alan Gillis <gillis5@tuolumne2152.llnl.gov> Co-authored-by: Daniel J. Vickers <dnlvickers5@gmail.com> Co-authored-by: Spencer Bryngelson <sbryngelson@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added the two DEALLOCATE calls for Res_gs (line 105, within viscous if statement) and Gs_rs (line 111) needed in src/simulation/m_riemann_solvers.fpp
Closes #1568.
Type of change
Testing
Ran test suite on personal machine using CPU for both --no-mpi and --mpi. Then ran test suite on Tuolumne in lustre5 storage, using ./mfc.sh test -j 16 --mpi --gpu acc -- -c tuo. All cases passed for all testing instances.
Checklist
Check these like this
[x]to indicate which of the below applies.See the developer guide for full coding standards.
GPU changes (expand if you modified
src/simulation/)AI code reviews
Reviews are not retriggered automatically. To request a review, comment on the PR:
@claude full review— Claude full review (also triggers on PR open/reopen/ready)claude-full-review— Claude full review via label