Skip to content

Feature: Add Dolfyn Turbulence Functionality#173

Merged
simmsa merged 54 commits into
MHKiT-Software:developfrom
simmsa:feat_dolfyn_turbulence
Sep 30, 2025
Merged

Feature: Add Dolfyn Turbulence Functionality#173
simmsa merged 54 commits into
MHKiT-Software:developfrom
simmsa:feat_dolfyn_turbulence

Conversation

@simmsa
Copy link
Copy Markdown
Contributor

@simmsa simmsa commented Aug 7, 2025

This PR is a WIP to add all functions necessary calculating turbulence quantities of interest in MHKiT-MATLAB using native matlab code.

@simmsa simmsa added this to the 0.7.0 milestone Aug 7, 2025
@akeeste
Copy link
Copy Markdown
Contributor

akeeste commented Aug 19, 2025 •
edited
Loading

@simmsa when this is ready @browniea has some bandwidth to review.

Is #102 still active and need a review or is it deprecated by this PR?

@simmsa
Copy link
Copy Markdown
Contributor Author

simmsa commented Sep 3, 2025

@akeeste I just closed #102, as is functionality will be superceeded by this PR. @browniea, thank you for being willing to review. I should have some more substantial code for review in the next day or two.

simmsa added 22 commits September 8, 2025 14:23
@simmsa
Dolfyn: Add dolfyn_stepsize function
a0899e0
@simmsa
Dolfyn: Update water_depth_from_pressure docstring
f246e1a
@simmsa
Dolfyn: Update dolfyn_read docstring
f08abe1
@simmsa
Utils: Add mhkit_nanmean function
e160c8d
@simmsa
Dolfyn: Add dolfyn_select function
5e5a796
@simmsa
Dolfyn: Add helper subtract_mean_from_dimension function
baa8d72
@simmsa
Dolfyn: Add reshape_for_ensemble function
e1a5193
@simmsa
Fix: Relax arguments block in mhkit_nanmean
5fbf846
@simmsa
Dolfyn: Add turbulence_intensity calculation
79cd30d
@simmsa
Dolfyn: Update title for depth plot
93c43a9
@simmsa
Signal: Add hann window function
623dee0
@simmsa
Signal: Add hann window function
c9494d6
@simmsa
Signal: Add hamming window function
98d7493
@simmsa
Signal: Add rectwin window
216b6fa
@simmsa
Signal: Add get_window function
79a7783
@simmsa
Dolfyn: Add dolfyn_psd_1D function
cd13ae0
@simmsa
Dolfyn: Add WIP adcp_example
3c9b2a3
@simmsa
Merge remote-tracking branch 'upstream/develop' into feat_dolfyn_turb…
19b0ca5 
…ulence
@simmsa
Signal: Add detrend array function
5f43d3a
@simmsa
Dolfyn: Add power_spectral_density function
24df75d
@simmsa
Fix: Incorrect tilt qoi logic in calc_tilt
2669fb2
@simmsa
Dolfyn: Add calculate_doppler_noise_level function
5a53e2a
@browniea
Copy link
Copy Markdown

browniea commented Sep 17, 2025

@simmsa is this ready for review or should I hold off?

simmsa added 18 commits September 19, 2025 14:22
@simmsa
Examples: ADCP, Fix PSD overlapping y axis cbar text
94b37b2
@simmsa
Dolfyn: Clean up power_spectral_density print statements
6419920
@simmsa
Examples: ADCP, clean up, prep for new version
ddaf7d1
@simmsa
Examples: ADCP: Fix reynolds stress equation syntax
7f33a98
@simmsa
Dolfyn: Clean up debugging print statements in calculate_turbulence_i…
0d3aefa 
…ntensity
@simmsa
Dolfyn: plot, use cmocean colors by default
73abcf0
@simmsa
Dolfyn: Add s-1 to PSD radians units
48763be
@simmsa
Dolfyn: Add calculate_dissipation_rate_LT83 function
a79e143
@simmsa
Dolfyn: Add calculate_dissipation_rate_profile function
fe7574d
@simmsa
Dolfyn: Add calculate_reynolds_stress_5beam function
e4fb77b
@simmsa
Dolfyn: Add calculate_velocity_shear function
d4fcc8e
@simmsa
Examples: Update adcp mlx and html
0411b35
@simmsa
Dolfyn: Average from wall clock start time
c97985e
@simmsa
Dolfyn: Fix args block in stepsize
39dba65
@simmsa
Dolfyn: Update bin average test
7e257ad
@simmsa
Dolfyn: lint new lines at end of files
a7b9e47
@simmsa
Dolfyn: Clean up docstrings
7ce68b7
@simmsa
Dolfyn: Add analysis workflow tests
65a3a2d
@simmsa simmsa marked this pull request as ready for review September 29, 2025 15:46
@simmsa
Copy link
Copy Markdown
Contributor Author

simmsa commented Sep 29, 2025

@browniea, this is good to go. Do you have any comments/feedback on this part of the turbulence implementation?

Issue #180 is unfortunately outside the scope of this PR, but is something that can be added in the future.

@simmsa simmsa modified the milestones: 0.7.0, 1.0 Sep 29, 2025
@simmsa simmsa mentioned this pull request Sep 29, 2025
Merged
@browniea browniea self-requested a review September 29, 2025 23:01
browniea
browniea approved these changes Sep 30, 2025
View reviewed changes
Copy link
Copy Markdown

@browniea browniea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a few issues reading in Teledyne ADCP files #180 an extra array dimension in the ds.vel structure.

@simmsa simmsa merged commit 0ad774e into MHKiT-Software:develop Sep 30, 2025
30 checks passed
@simmsa simmsa mentioned this pull request Sep 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@browniea browniea browniea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@simmsa @akeeste @browniea