Acoustics module#174
Merged
Merged
Conversation
jmcvey3
approved these changes
Sep 22, 2025
|
Looks good from a coding standpoint. |
Acoustics Module Standardization
simmsa
approved these changes
Sep 29, 2025
Contributor
simmsa
left a comment
There was a problem hiding this comment.
@hivanov-nrel, this looks good! My comments/fixes were added here:
Thank you for this addition!
Contributor
|
@hivanov-nrel, this is good to go. I will merge once the tests finish... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acoustics Module Parity
This PR is meant to bring the acoustics module from MHKiT-Python to MHKiT-MATLAB as part of the parity goal.
IO
read_hydrophoneread_soundtrapread_iclistenexport_audio--- Not implemented since matlab has a built-in audio player_read_wav_metadata--- this is not necessary since matlab have built in function to read audiofile_calculate_voltage_and_time--- this is not necessary since matlab have built in function to read audiofileAnalysis
_fmax_warningminimum_frequencysound_pressure_spectral_densityapply_calibrationsound_pressure_spectral_density_levelband_aggregatetime_aggregatenmfs_auditory_weightingsound_exposure_levelsound_pressure_level_band_sound_pressure_levelthird_octave_sound_pressure_leveldecidecade_sound_pressure_levelGraphics
plot_spectrogramplot_spectraReviewer notes
export_audiowas not implemented since matlab has a built-in audio playeraudioreadis significantly slower than python implementation. It can take several minutes to read in some of the example audio files. Interestingly, this is only when running the notebook examples. Otherwise the function runs fast during tests.Changelog info
Acoustics Module
To support users, an example notebook demonstrates the application of this module with workflows