Loads mler bug fix#179
Merged
Merged
Conversation
This reverts commit c4a990f.
Contributor
|
@hivanov-nrel, tests are passing and this appears to be fixed. Can you confirm? The root cause was some unnecessary transposing, likely caused by something I did to try to get the tests passing. LMK if you are good with the changes here. |
This reverts commit 2d20fd7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Correct bug where the phase angle is negative when it should be positive. The internal matlab function
anglereads in the provided RAO data as positive, whereas the corresponding function in Python reads this data in as negative. This accounts for the difference in signage on line 55.Issue
Closes #172