lint: clear ruff debt + repair CI lint job's pyproject config

The new lint job in ci.yml (added in 1b53585) surfaces ruff debt that
predates this branch — the project's previous CI never ran ruff. Most of
it is mechanical: SIM* return-direct rewrites, C4* comprehension
simplifications, I001 import sorts, F401 unused imports, UP015/UP032
modernizations.

What was changed
----------------
- Auto-applied ruff --fix --unsafe-fixes (109 fixes). Reverted one
  unsafe fix in src/pptx/opc/serialized.py (SIM401 wanted
  blob_reader.get(uri, None), but _blob_reader is a Container, not a
  Mapping — has no .get()). Added a noqa with explanation.
- Manually broke a long _GUID_RE line in tests/parts/test_custom_xml.py
  to fit the 100-char limit (E501).
- pyproject.toml [tool.ruff.lint]:
    * Renamed TCH001 -> TC001 (ruff renamed the rule).
    * Removed PT005 from ignore list — ruff removed the rule.

Verified
--------
- ruff check src tests   -> All checks passed
- pytest tests/          -> 2986 passed
- behave --stop          -> 54 features, 981 scenarios, 0 failed

Out of scope
------------
- ruff format would reformat 48 files. The lint job has
  'continue-on-error: true' on the format check, so that stays advisory
  for now. A repo-wide format pass is a separate dedicated PR.

Author: Matthew Horoszowski

pyproject.toml

@@ -129,7 +129,7 @@ select = [
     "PLR0402",  # -- Name compared with itself like `foo == foo` --
     "PT",       # -- flake8-pytest-style --
     "SIM",      # -- flake8-simplify --
-    "TCH001",   # -- detect typing-only imports not under `if TYPE_CHECKING` --
+    "TC001",    # -- detect typing-only imports not under `if TYPE_CHECKING` (formerly TCH001) --
     "UP015",    # -- redundant `open()` mode parameter (like "r" is default) --
     "UP018",    # -- Unnecessary {literal_type} call like `str("abc")`. (rewrite as a literal) --
     "UP032",    # -- Use f-string instead of `.format()` call --
@@ -139,7 +139,6 @@ select = [
 ignore = [
     "COM812",   # -- over aggressively insists on trailing commas where not desireable --
     "PT001",    # -- wants empty parens on @pytest.fixture where not used (essentially always) --
-    "PT005",    # -- flags mock fixtures with names intentionally matching private method name --
     "PT011",    # -- pytest.raises({exc}) too broad, use match param or more specific exception --
     "PT012",    # -- pytest.raises() block should contain a single simple statement --
     "SIM117",   # -- merge `with` statements for context managers that have same scope --

src/pptx/chart/axis.py

@@ -51,9 +51,7 @@ def has_major_gridlines(self):
         causes major gridlines to be displayed. Assigning |False| causes them
         to be removed.
         """
-        if self._element.majorGridlines is None:
-            return False
-        return True
+        return self._element.majorGridlines is not None
 
     @has_major_gridlines.setter
     def has_major_gridlines(self, value):
@@ -70,9 +68,7 @@ def has_minor_gridlines(self):
         causes minor gridlines to be displayed. Assigning |False| causes them
         to be removed.
         """
-        if self._element.minorGridlines is None:
-            return False
-        return True
+        return self._element.minorGridlines is not None
 
     @has_minor_gridlines.setter
     def has_minor_gridlines(self, value):
@@ -89,9 +85,7 @@ def has_title(self):
         causes an axis title to be added if not already present. Assigning
         |False| causes any existing title to be deleted.
         """
-        if self._element.title is None:
-            return False
-        return True
+        return self._element.title is not None
 
     @has_title.setter
     def has_title(self, value):
@@ -232,7 +226,7 @@ def visible(self):
         delete = self._element.delete_
         if delete is None:
             return False
-        return False if delete.val else True
+        return not delete.val
 
     @visible.setter
     def visible(self, value):
@@ -267,9 +261,7 @@ def has_text_frame(self):
         already present. Assigning |False| causes any existing text frame to
         be removed along with any text contained in the text frame.
         """
-        if self._title.tx_rich is None:
-            return False
-        return True
+        return self._title.tx_rich is not None
 
     @has_text_frame.setter
     def has_text_frame(self, value):
@@ -441,9 +433,8 @@ def crosses(self):
     @crosses.setter
     def crosses(self, value):
         cross_xAx = self._cross_xAx
-        if value == XL_AXIS_CROSSES.CUSTOM:
-            if cross_xAx.crossesAt is not None:
-                return
+        if value == XL_AXIS_CROSSES.CUSTOM and cross_xAx.crossesAt is not None:
+            return
         cross_xAx._remove_crosses()
         cross_xAx._remove_crossesAt()
         if value == XL_AXIS_CROSSES.CUSTOM:

src/pptx/chart/chart.py

@@ -115,9 +115,7 @@ def has_title(self):
         settings.
         """
         title = self._chartSpace.chart.title
-        if title is None:
-            return False
-        return True
+        return title is not None
 
     @has_title.setter
     def has_title(self, value):
@@ -229,9 +227,7 @@ def has_text_frame(self):
         already present. Assigning |False| causes any existing text frame to
         be removed along with its text and formatting.
         """
-        if self._title.tx_rich is None:
-            return False
-        return True
+        return self._title.tx_rich is not None
 
     @has_text_frame.setter
     def has_text_frame(self, value):

src/pptx/chart/data.py

@@ -391,9 +391,7 @@ def are_dates(self):
             return False
         first_cat_label = self[0].label
         date_types = (datetime.date, datetime.datetime)
-        if isinstance(first_cat_label, date_types):
-            return True
-        return False
+        return bool(isinstance(first_cat_label, date_types))
 
     @property
     def are_numeric(self):
@@ -414,9 +412,7 @@ def are_numeric(self):
         # the caller's input.
         first_cat_label = self[0].label
         numeric_types = (Number, datetime.date, datetime.datetime)
-        if isinstance(first_cat_label, numeric_types):
-            return True
-        return False
+        return bool(isinstance(first_cat_label, numeric_types))
 
     @property
     def depth(self):

src/pptx/chart/datalabel.py

@@ -177,9 +177,7 @@ def has_text_frame(self):
         dLbl = self._dLbl
         if dLbl is None:
             return False
-        if dLbl.xpath("c:tx/c:rich"):
-            return True
-        return False
+        return bool(dLbl.xpath("c:tx/c:rich"))
 
     @has_text_frame.setter
     def has_text_frame(self, value):

src/pptx/chart/plot.py

@@ -340,9 +340,7 @@ def _differentiate_line_chart_type(cls, plot):
 
         def has_line_markers():
             matches = lineChart.xpath('c:ser/c:marker/c:symbol[@val="none"]')
-            if matches:
-                return False
-            return True
+            return not matches
 
         if has_line_markers():
             return {
@@ -370,9 +368,7 @@ def _differentiate_radar_chart_type(cls, plot):
 
         def noMarkers():
             matches = radarChart.xpath("c:ser/c:marker/c:symbol")
-            if matches and matches[0].get("val") == "none":
-                return True
-            return False
+            return bool(matches and matches[0].get("val") == "none")
 
         if radar_style is None:
             return XL.RADAR
@@ -391,9 +387,7 @@ def noLine():
 
         def noMarkers():
             symbols = scatterChart.xpath("c:ser/c:marker/c:symbol")
-            if symbols and symbols[0].get("val") == "none":
-                return True
-            return False
+            return bool(symbols and symbols[0].get("val") == "none")
 
         scatter_style = scatterChart.xpath("c:scatterStyle")[0].get("val")
 

src/pptx/chart/xmlwriter.py

@@ -140,7 +140,7 @@ def pt_xml(self, values):
         in the overall data point sequence of the chart and is started at
         *offset*.
         """
-        xml = ('                <c:ptCount val="{pt_count}"/>\n').format(pt_count=len(values))
+        xml = (f'                <c:ptCount val="{len(values)}"/>\n')
 
         pt_tmpl = (
             '                <c:pt idx="{idx}">\n'

src/pptx/custom_xml.py

@@ -13,12 +13,12 @@
 from typing import TYPE_CHECKING, Iterable, Iterator, Literal, Sequence, Union, cast
 
 from pptx.opc.constants import RELATIONSHIP_TYPE as RT
-from pptx.opc.package import Part
 from pptx.oxml import parse_xml
-from pptx.oxml.xmlchemy import BaseOxmlElement
 from pptx.parts.custom_xml import CustomXmlPart, XmlPayload
 
 if TYPE_CHECKING:
+    from pptx.opc.package import Part
+    from pptx.oxml.xmlchemy import BaseOxmlElement
     from pptx.parts.presentation import PresentationPart
 
 

src/pptx/dml/effect.py

@@ -100,9 +100,7 @@ def inherit(self):
         Assigning |False| causes the inheritance link to be broken and **no**
         effects to appear on the shape.
         """
-        if self._element.effectLst is None:
-            return True
-        return False
+        return self._element.effectLst is None
 
     @inherit.setter
     def inherit(self, value):

src/pptx/opc/serialized.py

@@ -44,7 +44,9 @@ def rels_xml_for(self, partname: PackURI) -> bytes | None:
         instance.
         """
         blob_reader, uri = self._blob_reader, partname.rels_uri
-        return blob_reader[uri] if uri in blob_reader else None
+        # `_blob_reader` is a Container, not a Mapping — it has no `.get()`,
+        # so SIM401's "use blob_reader.get(uri, None)" rewrite would break.
+        return blob_reader[uri] if uri in blob_reader else None  # noqa: SIM401
 
     @lazyproperty
     def _blob_reader(self) -> _PhysPkgReader: