Skip to content

Commit e1e2dd0

Browse files
ostefanoMaxime Escourbiac
andauthored
Bump misp-core and add new OIDC library (#367)
* Integrate CertMichelin:OpenIDConnectClient #10599 * Add OpenID parameter in README.md * Keep jakub-onderka for compatibility * Bump misp-core --------- Co-authored-by: Maxime Escourbiac <maxime.escourbiac@michelin.com>
1 parent 519c2b8 commit e1e2dd0

6 files changed

Lines changed: 9 additions & 3 deletions

File tree

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,7 @@ For Okta, create a new application integration:
215215
OIDC_CODE_CHALLENGE_METHOD=S256
216216
OIDC_AUTH_METHOD="client_secret_post"
217217
OIDC_REDIRECT_URI="https://<MISP_URL>/users/login" # (same value set in Okta)
218+
OIDC_DISABLE_REQUEST_OBJECT=false
218219
```
219220
Valid options for OIDC_AUTH_METHOD are:
220221
- client_secret_post: tested

core/Dockerfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ RUN <<-EOF
105105
composer require --with-all-dependencies --no-interaction \
106106
elasticsearch/elasticsearch:^8.7.0 \
107107
jakub-onderka/openid-connect-php:^1.0.0 \
108+
certmichelin/openid-connect-php:1.3.0 \
108109
aws/aws-sdk-php
109110
fi
110111
EOF

core/files/configure_misp.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,8 @@ set_up_oidc() {
101101
\"default_org\": \"${OIDC_DEFAULT_ORG}\",
102102
\"mixedAuth\": ${OIDC_MIXEDAUTH},
103103
\"authentication_method\": \"${OIDC_AUTH_METHOD}\",
104-
\"redirect_uri\": \"${OIDC_REDIRECT_URI}\"
104+
\"redirect_uri\": \"${OIDC_REDIRECT_URI}\",
105+
\"disable_request_object\": \"${OIDC_DISABLE_REQUEST_OBJECT}\"
105106
}
106107
}" > /dev/null
107108

core/files/entrypoint.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ export AUTOCONF_ADMIN_KEY=${AUTOCONF_ADMIN_KEY:-true}
5555
export AUTOGEN_ADMIN_KEY=${AUTOGEN_ADMIN_KEY:-$AUTOCONF_ADMIN_KEY}
5656
export OIDC_ENABLE=${OIDC_ENABLE:-false}
5757
export OIDC_MIXEDAUTH=${OIDC_MIXEDAUTH:-false}
58+
export OIDC_DISABLE_REQUEST_OBJECT=${OIDC_DISABLE_REQUEST_OBJECT:-false}
5859
export LDAP_ENABLE=${LDAP_ENABLE:-false}
5960
export ENABLE_DB_SETTINGS=${ENABLE_DB_SETTINGS:-false}
6061
export ENABLE_BACKGROUND_UPDATES=${ENABLE_BACKGROUND_UPDATES:-false}

docker-compose.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,7 @@ services:
167167
- "OIDC_REDIRECT_URI=${OIDC_REDIRECT_URI}"
168168
- "OIDC_SCOPES=${OIDC_SCOPES}"
169169
- "OIDC_LOGOUT_URL=${OIDC_LOGOUT_URL}"
170+
- "OIDC_DISABLE_REQUEST_OBJECT=${OIDC_DISABLE_REQUEST_OBJECT}"
170171
# APACHESECUREAUTH authentication settings
171172
- "APACHESECUREAUTH_LDAP_OLD_VAR_DETECT=${LDAP_ENABLE}"
172173
- "APACHESECUREAUTH_LDAP_ENABLE=${APACHESECUREAUTH_LDAP_ENABLE:-${LDAP_ENABLE}}"

template.env

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# Build-time variables
33
##
44

5-
CORE_TAG=v2.5.31
5+
CORE_TAG=v2.5.32
66
# CORE_FLAVOR=standard
77
MODULES_TAG=v3.0.5
88
# MODULES_FLAVOR=standard
@@ -163,7 +163,7 @@ SYNCSERVERS_1_PULL_RULES=
163163
# Disable CA refresh
164164
# DISABLE_CA_REFRESH=true
165165

166-
# Enable OIDC authentication, according to https://github.com/MISP/MISP/blob/2.4/app/Plugin/OidcAuth/README.md
166+
# Enable OIDC authentication, according to https://github.com/MISP/MISP/blob/2.5/app/Plugin/OidcAuth/README.md
167167
# OIDC_ENABLE=true
168168
# OIDC_PROVIDER_URL=
169169
# OIDC_ISSUER=
@@ -178,6 +178,7 @@ SYNCSERVERS_1_PULL_RULES=
178178
# OIDC_REDIRECT_URI=
179179
# OIDC_SCOPES="[\"profile\", \"email\"]"
180180
# OIDC_LOGOUT_URL=
181+
# OIDC_DISABLE_REQUEST_OBJECT=false
181182

182183
# Enable LDAP (using the ApacheSecureAuth component) authentication, according to https://github.com/MISP/MISP/issues/6189
183184
# NOTE: Once you enable LDAP authentication with the ApacheSecureAuth component,

0 commit comments

Comments
 (0)