OIDC_LOGOUT_URL is overwritten by set_up_custom_auth function

[Mapmark]

It looks like whenever you end up placing OIDC_LOGOUT_URL, , it sticks for awhile, but then once it goes into the set_up_custom_auth function, it gets overwritten

Seems it'll happen whether CUSTOM_AUTH_ENABLE is true or not

it gets made here:

misp-docker/core/files/configure_misp.sh

Line 128 in cc45da7

sudo -u www-data /var/www/MISP/app/Console/cake Admin setSetting -q "Plugin.CustomAuth_custom_logout" "${OIDC_LOGOUT_URL_COMPLETE}"

But then it steps into the function and gets erased out.

misp-docker/core/files/configure_misp.sh

Line 371 in cc45da7

if [[ -n "$CUSTOM_AUTH_CUSTOM_LOGOUT" ]]; then

misp-docker/core/files/configure_misp.sh

Line 394 in cc45da7

sudo -u www-data /var/www/MISP/app/Console/cake Admin setSetting -q -n "Plugin.CustomAuth_custom_logout"

passing env variables below can get past it.

  CUSTOM_AUTH_ENABLE: "true"
  CUSTOM_AUTH_CUSTOM_LOGOUT: "{{ keycloak_auth_url }}/realms/{{ keycloak_realm }}/protocol/openid-connect/logout"
  OIDC_LOGOUT_URL: "{{ keycloak_auth_url }}/realms/{{ keycloak_realm }}/protocol/openid-connect/logout" # <-- this gets overriten , but the custom_auth_custom_logout will remain 

[ostefano]

Clearly a logic bug.

Feel free to open a PR with a proper fix (possible CUSTOM_AUTH_CUSTOM_LOGOUT checking whether OIDC_LOGOUT_URL is set, and if so, do nothing instead of cleaning up the value).