Return 404 for missing CSS assets instead of routing through CakePHP#425
Merged
Merged
Conversation
ae20bfd to
98741ac
Compare
ostefano
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change ensures that missing CSS assets are handled by Nginx instead of being forwarded to CakePHP.
Problem
The application was configured with:
When a CSS-related asset (for example, a .css.map file) did not exist under /css/, the request fell through to index.php and was interpreted by CakePHP as an application route.
In practice, this caused asset requests to be treated as navigational URLs, which could interfere with authentication redirect logic and result in invalid login redirection behavior.
Solution
Handle missing CSS asset requests at the web server level so they return a proper 404 Not Found response instead of being routed through CakePHP.
This is done by restricting /css/ to static file resolution only.
Impact