Skip to content

chg: [email_import] avoid treating non http https urls as url #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adulau merged 1 commit into from
Apr 27, 2026
Merged

chg: [email_import] avoid treating non http https urls as url #774

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions misp_modules/modules/import_mod/email_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,10 @@ def dict_handler(request: dict):
for url in urls:
if not url:
continue
url_object = URLObject(url, standalone=False)
try:
url_object = URLObject(url, standalone=False)
except ValueError:
continue
file_objects.append(url_object)
email_object.add_reference(url_object.uuid, "includes", "URL in email body")

Expand Down Expand Up @@ -344,9 +347,15 @@ def __init__(self, urls=None):

def handle_starttag(self, tag, attrs):
if tag == "a":
self.urls.append(dict(attrs).get("href"))
value = self.urls.append(dict(attrs).get("href"))
if tag == "img":
self.urls.append(dict(attrs).get("src"))
value = self.urls.append(dict(attrs).get("src"))
else:
return

# avoid references like internal cid:
if value and value.lower().startswith(("http://", "https://")):
self.urls.append(value)


def introspection():
Expand Down
Loading