Merge pull request #2015 from Chessing234/fix/mimic-iv-height-coalesce-h2

Fix FULL OUTER JOIN COALESCE in MIMIC-IV height concept

Author: alistairewj

mimic-iv/concepts/measurement/height.sql

@@ -25,9 +25,9 @@ WITH ht_in AS (
 -- merge cm/height, only take 1 value per charted row
 , ht_stg0 AS (
     SELECT
-        COALESCE(h1.subject_id, h1.subject_id) AS subject_id
-        , COALESCE(h1.stay_id, h1.stay_id) AS stay_id
-        , COALESCE(h1.charttime, h1.charttime) AS charttime
+        COALESCE(h1.subject_id, h2.subject_id) AS subject_id
+        , COALESCE(h1.stay_id, h2.stay_id) AS stay_id
+        , COALESCE(h1.charttime, h2.charttime) AS charttime
         , COALESCE(h1.height, h2.height) AS height
     FROM ht_cm h1
     FULL OUTER JOIN ht_in h2

mimic-iv/concepts_duckdb/measurement/height.sql

@@ -21,9 +21,9 @@ WITH ht_in AS (
     NOT c.valuenum IS NULL AND c.itemid = 226730
 ), ht_stg0 AS (
   SELECT
-    COALESCE(h1.subject_id, h1.subject_id) AS subject_id,
-    COALESCE(h1.stay_id, h1.stay_id) AS stay_id,
-    COALESCE(h1.charttime, h1.charttime) AS charttime,
+    COALESCE(h1.subject_id, h2.subject_id) AS subject_id,
+    COALESCE(h1.stay_id, h2.stay_id) AS stay_id,
+    COALESCE(h1.charttime, h2.charttime) AS charttime,
     COALESCE(h1.height, h2.height) AS height
   FROM ht_cm AS h1
   FULL OUTER JOIN ht_in AS h2

mimic-iv/concepts_postgres/measurement/height.sql

@@ -22,9 +22,9 @@ WITH ht_in AS (
     NOT c.valuenum IS NULL AND /* Height cm */ c.itemid = 226730
 ), ht_stg0 /* merge cm/height, only take 1 value per charted row */ AS (
   SELECT
-    COALESCE(h1.subject_id, h1.subject_id) AS subject_id,
-    COALESCE(h1.stay_id, h1.stay_id) AS stay_id,
-    COALESCE(h1.charttime, h1.charttime) AS charttime,
+    COALESCE(h1.subject_id, h2.subject_id) AS subject_id,
+    COALESCE(h1.stay_id, h2.stay_id) AS stay_id,
+    COALESCE(h1.charttime, h2.charttime) AS charttime,
     COALESCE(h1.height, h2.height) AS height
   FROM ht_cm AS h1
   FULL OUTER JOIN ht_in AS h2