Skip to content

Commit b2cfb6e

Browse files
committed
remove push from ci/mysql/sqlite, add it to pre-release bq
1 parent d50c21b commit b2cfb6e

4 files changed

Lines changed: 8 additions & 20 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,20 +13,14 @@ on:
1313
pull_request_review:
1414
types: [submitted]
1515
workflow_dispatch:
16-
# TEMP: test on push to branch
17-
push:
18-
branches:
19-
- alistair/more_gh_action_shenanigans
2016

2117
jobs:
2218
psql:
23-
# TEMP: 'push' added to run on branch push
24-
if: github.event_name == 'workflow_dispatch' || github.event_name == 'push' || github.event.review.state == 'approved'
19+
if: github.event_name == 'workflow_dispatch' || github.event.review.state == 'approved'
2520
uses: ./.github/workflows/build-psql.yml
2621

2722
duckdb:
28-
# TEMP: 'push' added to run on branch push
29-
if: github.event_name == 'workflow_dispatch' || github.event_name == 'push' || github.event.review.state == 'approved'
23+
if: github.event_name == 'workflow_dispatch' || github.event.review.state == 'approved'
3024
uses: ./.github/workflows/build-duckdb.yml
3125

3226
psql-concepts:

.github/workflows/mysql.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,11 @@ name: mysql demo db build
22
on:
33
pull_request_review:
44
types: [submitted]
5-
# TEMP: test on push to branch
6-
push:
7-
branches:
8-
- alistair/more_gh_action_shenanigans
95

106
jobs:
117
mimic-iv-mysql:
128
# only run if PR is approved
13-
# TEMP: also run on push
14-
if: github.event_name == 'push' || github.event.review.state == 'approved'
9+
if: github.event.review.state == 'approved'
1510
runs-on: ubuntu-22.04
1611

1712
steps:

.github/workflows/prerelease_bigquery.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ name: Pre-release concept build on mimiciv_derived
55
on:
66
release:
77
types: [prereleased]
8+
# TEMP: test on push to branch
9+
push:
10+
branches:
11+
- alistair/more_gh_action_shenanigans
812

913
jobs:
1014
build-and-validate:

.github/workflows/sqlite.yml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,16 +2,11 @@ name: sqlite demo db build
22
on:
33
pull_request_review:
44
types: [submitted]
5-
# TEMP: test on push to branch
6-
push:
7-
branches:
8-
- alistair/more_gh_action_shenanigans
95

106
jobs:
117
mimic-iv-sqlite:
128
# only run if PR is approved
13-
# TEMP: also run on push
14-
if: github.event_name == 'push' || github.event.review.state == 'approved'
9+
if: github.event.review.state == 'approved'
1510
runs-on: ubuntu-latest
1611
container: python:3.10
1712

0 commit comments

Comments
 (0)