ci: fix SQLFluff annotation permissions for fork PRs - #2148
Open
Chessing234 wants to merge 6 commits into
Open
Conversation
Fork PRs need an explicit checks:write grant so the annotation action can post findings without relying on the default GITHUB_TOKEN scope. Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid running the annotations action against a missing annotations.json on PRs that do not touch mimic-iv/concepts, and tolerate unauthorized check writes with ignore-unauthorized-error. Co-authored-by: Cursor <cursoragent@cursor.com>
Spell out why the workflow sets checks:write and ignore-unauthorized-error so future edits do not reintroduce continue-on-error. Co-authored-by: Cursor <cursoragent@cursor.com>
Point contributors at the workflow that reviews changed MIMIC-IV concept SQL. Co-authored-by: Cursor <cursoragent@cursor.com>
Mirrors the PR workflow so contributors can lint mimic-iv/concepts changes before pushing. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jul 31, 2026
Contributor
Author
|
This unblocks fork PRs: every recent Chessing234 mimic-iv PR is red only on the Annotate step ( |
ignore-unauthorized-error does not catch the fork 403 (Resource not accessible by integration). Skip Annotate when head.repo != base repo so lint-mimic-iv can stay green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contents: read+checks: write, skip annotate when no concept SQL changed, and setignore-unauthorized-error: true.Test plan
mimic-iv/concepts/**/*.sql— SQLFluff job should skip lint/annotate cleanly.sqlfile — annotations post (or are ignored gracefully on forks)./scripts/lint_changed_mimic_iv_concepts.shagainst a branch with concept editsMade with Cursor