docs(mimic-iv): timing notes for chartevents vs icustays windows (#1961) - #2151
Open
Chessing234 wants to merge 8 commits into
Open
docs(mimic-iv): timing notes for chartevents vs icustays windows (#1961)#2151Chessing234 wants to merge 8 commits into
Chessing234 wants to merge 8 commits into
Conversation
Explain why chartevents can fall after icustays.outtime (MIT-LCP#1961). Co-authored-by: Cursor <cursoragent@cursor.com>
Surface the MIT-LCP#1961 caveat from module and repo entrypoints. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep MIT-LCP#1961 audit SQL out of the official derived-concept tree. Co-authored-by: Cursor <cursoragent@cursor.com>
Give researchers a concrete count for the MIT-LCP#1961 offset pattern. Co-authored-by: Cursor <cursoragent@cursor.com>
Complement the after-outtime audit for MIT-LCP#1961 sensitivity checks. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep MIT-LCP#1961 resolved as documentation, not a silent data patch. Co-authored-by: Cursor <cursoragent@cursor.com>
Fork tokens cannot create check runs; keep lint green with ignore-unauthorized-error and skip annotate when no concept SQL changed. Co-authored-by: Cursor <cursoragent@cursor.com>
ignore-unauthorized-error does not catch the fork 403 (Resource not accessible by integration). Skip Annotate when head.repo != base repo so lint-mimic-iv can stay green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
icu.chartevents.charttimecan fall aftericustays.outtime(late charting, clock skew, constructed stay windows).mimic-iv/README.md/ repo README.mimic-iv/concepts/documentation/.Test plan
mimic-iv/docs/CHARTEVENTS_TIMING.mdagainst Errors in the charttime or stayid of chartevens #1961chartevents_after_outtime.sqlon a local buildCloses #1961
Made with Cursor