fix absolute_primal_residual bug when using Linf norm (#79)

ZedongPeng · web-flow · commit c28d2c9032f4 · 2026-02-14T15:36:52.000-05:00
diff --git a/src/utils.cu b/src/utils.cu
@@ -836,6 +836,7 @@ void compute_residual(pdhg_solver_state_t *state, norm_type_t optimality_norm)
         CUBLAS_CHECK(cublasDnrm2_v2_64(
             state->blas_handle, state->num_constraints, state->primal_residual, 1, &state->absolute_primal_residual));
     }
+    state->absolute_primal_residual /= state->constraint_bound_rescaling;
 
     if (optimality_norm == NORM_TYPE_L_INF)
     {
@@ -844,7 +845,6 @@ void compute_residual(pdhg_solver_state_t *state, norm_type_t optimality_norm)
     }
     else
     {
-        state->absolute_primal_residual /= state->constraint_bound_rescaling;
         CUBLAS_CHECK(cublasDnrm2_v2_64(
             state->blas_handle, state->num_variables, state->dual_residual, 1, &state->absolute_dual_residual));
     }

Original file line number	Diff line number	Diff line change
`@@ -836,6 +836,7 @@ void compute_residual(pdhg_solver_state_t *state, norm_type_t optimality_norm)`
`836`	`836`	`CUBLAS_CHECK(cublasDnrm2_v2_64(`
`837`	`837`	`state->blas_handle, state->num_constraints, state->primal_residual, 1, &state->absolute_primal_residual));`
`838`	`838`	`}`
	`839`	`+ state->absolute_primal_residual /= state->constraint_bound_rescaling;`
`839`	`840`
`840`	`841`	`if (optimality_norm == NORM_TYPE_L_INF)`
`841`	`842`	`{`
`@@ -844,7 +845,6 @@ void compute_residual(pdhg_solver_state_t *state, norm_type_t optimality_norm)`
`844`	`845`	`}`
`845`	`846`	`else`
`846`	`847`	`{`
`847`		`- state->absolute_primal_residual /= state->constraint_bound_rescaling;`
`848`	`848`	`CUBLAS_CHECK(cublasDnrm2_v2_64(`
`849`	`849`	`state->blas_handle, state->num_variables, state->dual_residual, 1, &state->absolute_dual_residual));`
`850`	`850`	`}`