Digitized theses workflow retrieves item handles for synced replacement theses

[jonavellecuerdo]

Purpose and background context

This PR updates the digitized theses workflow to retrieve item handles for replacement theses during the batch creation process when synced=True (i.e., the batch folder was synced from the DSC S3 bucket in Stage to the DSC S3 bucket in Prod).

As shown in DigitizedTheses.prepare_batch, when synced=True, the workflow derives a list of ItemSubmissions based on the contents of the batch folder synced to S3_BUCKET_SUBMISSION_ASSETS rather than repeating the steps outlined in DigitizedTheses._create_batch_in_s3. Effectively, this means:

• Skipping the step that syncs the batch from the workspace S3 bucket into DSC
• Skipping downloading of metadata from Alma
• Skipping checks via DSpace client to determine new, replacement, or skipped theses

When the batch was previously prepared and synced=True, all this information can be derived from the contents of the batch folder (e.g., the thesis type is determined by the subfolder the item submission is located in dsc-upload/digitized-theses/batch/<thesis-type>/).

However, as noted in this Copilot review, DigitizedTheses._get_item_submissions_from_synced_batch was missing a step to retrieve the handle for a DSpace item in the case of a replacement thesis. This PR adds a new code block, which requires using a DSpace client to retrieve the Item object from DSpace and extract the handle attribute.

Notes:

• Also updated the method to create an instance of ItemSubmission at the beginning so that the method can directly assign attributes to the instance.

How can a reviewer manually see the effects of these changes?

Review the added unit test.

Note: While it was straightforward to add a unit test for the synced=True path, creating unit tests for synced=False path (i.e., DigitizedTheses._create_batch_in_s3) is harder given all the steps involved. That said, there are unit tests for the smaller sub-methods it relies on + previous testing with MinIO demonstrates the code works as expected. Just continuing to share with reviewers that improving/adding unit tests continue to be on my mind!

Includes new or updated dependencies?

NO

Changes expectations for external applications?

NO

What are the relevant tickets?

• https://mitlibraries.atlassian.net/browse/IN-1756

Code review

• Code review best practices are documented here and you are encouraged to have a constructive dialogue with your reviewers about their preferences and expectations.

[coveralls]

Coverage Report for CI Build 26885385138

Warning

No base build found for commit c971b02 on main.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 83.35%

Details

• Patch coverage: 6 uncovered changes across 1 file (16 of 22 lines covered, 72.73%).

Uncovered Changes

File	Changed	Covered	%
dsc/workflows/digitized_theses/workflow.py	22	16	72.73%

Coverage Regressions

Requires a base build to compare against. How to fix this →

---

Coverage Stats

Relevant Lines:	2048
Covered Lines:	1707
Line Coverage:	83.35%
Coverage Strength:	0.83 hits per line

---

💛 - Coveralls

[Copilot]

Pull request overview

Updates the digitized theses workflow's synced-batch path to retrieve a DSpace handle for replacement theses by calling _get_item_from_dspace, and refactors the item submission construction to assign status/status_details per thesis type. Also replaces string status literals with ItemSubmissionStatus enum values in _create_batch_in_s3.

Changes:

• In _get_item_submissions_from_synced_batch, build ItemSubmission first, then look up DSpace handle for replacement theses and set status/details accordingly.
• Switch hard-coded status strings to ItemSubmissionStatus enum in _create_batch_in_s3 and consolidate the item_submissions.append call.
• Add a unit test for the synced-batch handle retrieval path; rename mock_s3_digitized_theses fixture to mock_s3_digitized_theses_dsc.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
dsc/workflows/digitized_theses/workflow.py	Adds DSpace handle lookup for replacement theses in synced-batch flow; switches to enum-based statuses in _create_batch_in_s3.
tests/workflows/digitized_theses/test_workflow.py	Renames fixture and adds a unit test for _get_item_submissions_from_synced_batch.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jonavellecuerdo]

@ehanson8 Addressed initial Copilot review!

[ehanson8]

Looking good but some structure questions

[ehanson8]

Great work!