Skip to content

Commit a89a117

Browse files
Remove FooterHelper and default footer messaging
** Why are these changes being introduced: * During initial prototyping of this theme, I put together a simple helper class to try and figure out how they work, and what they might be useful for. At this stage of the project, though, I'm not sure that we will have a need for them - so it is time to remove it. (The Freedome theme has a suitable example, in the wild, of what a helper class might do, by the way) ** Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/post-69 ** How does this address that need: * This removes the FooterHelper class, the reference to it in the config.ini, and the call to it in the page layout template. * This also removes the entire <footer> element that was part of the default page layout, which included a "Build with Omeka S" phrase that we don't want to preserve. * Finally, this updates the Makefile's deploy workflow to remove the reference to the now-deleted helper folder. ** Document any side effects to this change: * This isn't a side effect per se, but if we ever decide to add a helper down the road, like with the addition of any other deployable folder, we will need to keep the Makefile's deploy steps in sync.
1 parent 5ba1158 commit a89a117

4 files changed

Lines changed: 0 additions & 27 deletions

File tree

Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,5 +41,4 @@ deploy: ## Deploys the theme on a host server
4141
rsync --recursive --delete asset/img/ /var/www/html/themes/mitlibraries-theme-omeka/asset/img/
4242
rsync --recursive --delete asset/js/ /var/www/html/themes/mitlibraries-theme-omeka/asset/js/
4343
rsync --recursive --delete config/ /var/www/html/themes/mitlibraries-theme-omeka/config/
44-
rsync --recursive --delete helper/ /var/www/html/themes/mitlibraries-theme-omeka/helper/
4544
rsync --recursive --delete view/ /var/www/html/themes/mitlibraries-theme-omeka/view/

config/theme.ini

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ theme_link = "https://github.com/MITLibraries/mitlibraries-theme-omeka"
77
author_link = "https://libraries.mit.edu"
88
omeka_version_constraint = "^4.0.0"
99

10-
helpers[] = "FooterHelper"
11-
1210
[config]
1311
elements.banner.name = "banner"
1412
elements.banner.type = "Omeka\Form\Element\Asset"

helper/FooterHelper.php

Lines changed: 0 additions & 20 deletions
This file was deleted.

view/layout/layout.phtml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,5 @@ $userBar = $this->userBar();
9696
</div>
9797
<?php echo $this->partial('common/footer-site-slim'); ?>
9898
</div>
99-
<footer>
100-
<?php echo $this->FooterHelper(''); ?>
101-
<span class="powered-by"><?php echo $translate('Powered by Omeka S'); ?></span>
102-
</footer>
10399
</body>
104100
</html>

0 commit comments

Comments
 (0)