rubocop

Author: jazairi

app/helpers/results_helper.rb

@@ -86,23 +86,23 @@ def article?(format)
   # @param result [Hash] A normalized Primo result hash
   # @return [Boolean] True if the result has links, availability, or ThirdIron/OpenAlex triggers
   def result_get?(result)
-    has_renderable_links?(result) ||
+    renderable_links?(result) ||
       result[:availability].present? ||
       (Feature.enabled?(:oa_always) && article?(result[:format])) ||
-      has_thirdiron_content?(result)
+      thirdiron_content?(result)
   end
 
   private
 
-  def has_renderable_links?(result)
+  def renderable_links?(result)
     return false unless result[:links].present?
     return true if Feature.enabled?(:record_link)
 
     # If record_link is disabled, exclude results that have ONLY "full record" links
     result[:links].any? { |link| link['kind'].downcase != 'full record' }
   end
 
-  def has_thirdiron_content?(result)
+  def thirdiron_content?(result)
     ThirdIron.enabled? && (
       result[:doi].present? ||
       result[:pmid].present? ||

test/helpers/results_helper_test.rb

@@ -184,11 +184,11 @@ class ResultsHelperTest < ActionView::TestCase
   test 'result_get? returns true when result has both full record and PDF links even if record_link feature is disabled' do
     ClimateControl.modify(FEATURE_RECORD_LINK: nil, THIRDIRON_ID: nil, THIRDIRON_KEY: nil, FEATURE_OA_ALWAYS: nil) do
       assert result_get?({
-        links: [
-          { 'kind' => 'Full Record', 'url' => 'https://example.com' },
-          { 'kind' => 'PDF', 'url' => 'https://pdf.example.com' }
-        ]
-      })
+                           links: [
+                             { 'kind' => 'Full Record', 'url' => 'https://example.com' },
+                             { 'kind' => 'PDF', 'url' => 'https://pdf.example.com' }
+                           ]
+                         })
     end
   end
 end