Refactor full record URL evaluation to helper method

Author: jazairi

app/helpers/results_helper.rb

@@ -81,6 +81,16 @@ def article?(format)
     format.match?(/\barticle\b/i)
   end
 
+  # Extracts the full record URL from a result's links
+  #
+  # @param result [Hash] A normalized result hash with :links
+  # @return [String, nil] The URL of the 'full record' link, or nil if not found
+  def full_record_url(result)
+    return unless result.is_a?(Hash)
+
+    result[:links]&.find { |link| link['kind'] == 'full record' }&.dig('url')
+  end
+
   # Determines if a result has any fulfillment links to render
   #
   # @param result [Hash] A normalized Primo result hash

app/views/search/_result_primo.html.erb

@@ -3,8 +3,8 @@
     <div class="title-lockup">
       <%# NOTE: the order of the two items in this lockup are being swapped visually with CSS. The markup is ordered to make the screen reading experience more logical %>
       <h3 class="record-title">
-        <% if result[:links]&.find { |link| link['kind'] == 'full record' } %>
-          <%= link_to(result[:title], result[:links].find { |link| link['kind'] == 'full record' }['url'], data: { content_piece: 'Result Title' }) %>
+        <% if full_record_url(result) %>
+          <%= link_to(result[:title], full_record_url(result), data: { content_piece: 'Result Title' }) %>
         <% else %>
           <%= result[:title] %>
         <% end %>
@@ -122,8 +122,7 @@
         <%# Trigger BrowZine lookup (render inside result-get so injected HTML
             is part of the flex `.result-get` area and receives expected styles) %>
         <% if ThirdIron.enabled? && result[:format].downcase == 'journal' && result[:issn].present? %>
-          <% full_record_url = result[:links]&.find { |link| link['kind'] == 'full record' }&.dig('url') %>
-          <%= render(partial: 'trigger_browzine', locals: { issn: result[:issn], full_record_url: full_record_url }) %>
+          <%= render(partial: 'trigger_browzine', locals: { issn: result[:issn], full_record_url: full_record_url(result) }) %>
         <% end %>
       </div>
       <% end %>

test/helpers/results_helper_test.rb

@@ -191,4 +191,38 @@ class ResultsHelperTest < ActionView::TestCase
                          })
     end
   end
+
+  test 'full_record_url returns the URL when result has a full record link' do
+    result = {
+      links: [
+        { 'kind' => 'PDF', 'url' => 'https://pdf.example.com' },
+        { 'kind' => 'full record', 'url' => 'https://primo.example.com/record' }
+      ]
+    }
+    assert_equal 'https://primo.example.com/record', full_record_url(result)
+  end
+
+  test 'full_record_url returns nil when result has no links' do
+    result = {}
+    assert_nil full_record_url(result)
+  end
+
+  test 'full_record_url returns nil when result has links but no full record link' do
+    result = {
+      links: [
+        { 'kind' => 'PDF', 'url' => 'https://pdf.example.com' },
+        { 'kind' => 'HTML', 'url' => 'https://html.example.com' }
+      ]
+    }
+    assert_nil full_record_url(result)
+  end
+
+  test 'full_record_url returns nil when result is nil' do
+    assert_nil full_record_url(nil)
+  end
+
+  test 'full_record_url returns nil when result[:links] is nil' do
+    result = { links: nil }
+    assert_nil full_record_url(result)
+  end
 end