Removes bot_challenge_page gem#233
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 18377963873Details
💛 - Coveralls |
This was an interesting idea, but it wasn't triggering enough for to warrant the frustration the upgrade process caused when the gem entirely changed under the hood. I'm sure it made sense, but it was easier to remove it than update the configs to work on newer versions. We may bring it back eventually if it stabilizes or our needs warrant it.
5a2863e to
7f4d294
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was an interesting idea, but it wasn't triggering enough for to warrant the frustration the upgrade process caused when the gem entirely changed under the hood. I'm sure it made sense, but it was easier to remove it than update the configs to work on newer versions. We may bring it back eventually if it stabilizes or our needs warrant it.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing