Merge pull request #955 from MITLibraries/use-411-use-412

Add support for semantic search

Author: jazairi

.env.test

@@ -2,3 +2,7 @@ EMAIL_FROM=fake@example.com
 EMAIL_URL_HOST=localhost:3000
 JWT_SECRET_KEY=3862fc949629030de4259b88f6e8f7c3702b2fabfc68d00d46fb7f9f70110690b526997ef4d77765ffa010d8aba440286af39947d0c85287174d99be2db14987
 OPENSEARCH_INDEX=all-current
+AWS_ACCESS_KEY_ID=test-key
+AWS_SECRET_ACCESS_KEY=test-secret
+AWS_REGION=us-east-1
+TIMDEX_SEMANTIC_BUILDER_FUNCTION_NAME=timdex-semantic-builder-test

Gemfile

@@ -3,6 +3,7 @@ git_source(:github) { |repo| "https://github.com/#{repo}.git" }
 
 ruby '3.4.8'
 
+gem 'aws-sdk-lambda'
 gem 'bootsnap', require: false
 gem 'devise'
 gem 'faraday_middleware-aws-sigv4'
@@ -48,6 +49,7 @@ group :test do
   gem 'capybara'
   gem 'climate_control'
   gem 'minitest', '< 6' # required for Rails 7.2.3
+  gem 'mocha'
   gem 'selenium-webdriver'
   gem 'simplecov', require: false
   gem 'simplecov-lcov', require: false

Gemfile.lock

@@ -90,6 +90,18 @@ GEM
       rake (>= 10.4, < 14.0)
     ast (2.4.3)
     aws-eventstream (1.4.0)
+    aws-partitions (1.1232.0)
+    aws-sdk-core (3.244.0)
+      aws-eventstream (~> 1, >= 1.3.0)
+      aws-partitions (~> 1, >= 1.992.0)
+      aws-sigv4 (~> 1.9)
+      base64
+      bigdecimal
+      jmespath (~> 1, >= 1.6.1)
+      logger
+    aws-sdk-lambda (1.176.0)
+      aws-sdk-core (~> 3, >= 3.244.0)
+      aws-sigv4 (~> 1.5)
     aws-sigv4 (1.12.1)
       aws-eventstream (~> 1, >= 1.0.2)
     base64 (0.3.0)
@@ -205,6 +217,7 @@ GEM
       jekyll (>= 3.8, < 5.0)
     jekyll-watch (2.2.1)
       listen (~> 3.0)
+    jmespath (1.6.2)
     json (2.18.1)
     json-schema (6.1.0)
       addressable (~> 2.8)
@@ -245,6 +258,8 @@ GEM
     mini_mime (1.1.5)
     mini_portile2 (2.8.9)
     minitest (5.27.0)
+    mocha (3.1.0)
+      ruby2_keywords (>= 0.0.5)
     msgpack (1.8.0)
     multi_json (1.19.1)
     net-http (0.9.1)
@@ -373,6 +388,7 @@ GEM
       rubocop (>= 1.75.0, < 2.0)
       rubocop-ast (>= 1.44.0, < 2.0)
     ruby-progressbar (1.13.0)
+    ruby2_keywords (0.0.5)
     rubyzip (2.4.1)
     safe_yaml (1.0.5)
     sass-embedded (1.97.2)
@@ -461,6 +477,7 @@ PLATFORMS
 
 DEPENDENCIES
   annotate
+  aws-sdk-lambda
   bootsnap
   byebug
   capybara
@@ -479,6 +496,7 @@ DEPENDENCIES
   lograge
   minitest (< 6)
   mitlibraries-theme!
+  mocha
   opensearch-ruby
   pg
   puma

README.md

@@ -45,8 +45,8 @@ The test recording process is as follows:
 - Set the following values to whatever cluster you want to connect to in `.env` (Note: `.env` is preferred over `.env.test` because it is already in our `.gitignore` and will work together with `.env.test`.)
   - OPENSEARCH_URL
   - AWS_OPENSEARCH=true
-  - AWS_OPENSEARCH_ACCESS_KEY_ID
-  - AWS_OPENSEARCH_SECRET_ACCESS_KEY
+  - AWS_ACCESS_KEY_ID
+  - AWS_SECRET_ACCESS_KEY
   - AWS_REGION
 - Delete any cassette you want to regenerate (for new tests, you can skip this). If you are making a graphql test, nest your cassette inside the `opensearch_init` cassette.
 
@@ -158,29 +158,31 @@ locally.
 
 ## Production required Environment Variables
 
-- `AWS_OPENSEARCH`: boolean. Set to true to enable AWSv4 Signing
-- `AWS_OPENSEARCH_ACCESS_KEY_ID`
-- `AWS_OPENSEARCH_SECRET_ACCESS_KEY`
-- `AWS_REGION`
+- `AWS_ACCESS_KEY_ID`: AWS credentials for OpenSearch and Lambda
+- `AWS_SECRET_ACCESS_KEY`: AWS credentials for OpenSearch and Lambda
+- `AWS_REGION`: AWS region for OpenSearch and Lambda services
+- `AWS_OPENSEARCH`: boolean. Set to true to enable AWSv4 Signing for OpenSearch
 - `OPENSEARCH_INDEX`: Opensearch index or alias to query, default will be to search all indexes which is generally not
                       expected. `timdex` or `all-current` are aliases used consistently in our data pipelines, with
                       `timdex` being most likely what most use cases will want.
 - `OPENSEARCH_URL`: Opensearch URL, defaults to `http://localhost:9200`
+- `TIMDEX_SEMANTIC_BUILDER_FUNCTION_NAME`: AWS Lambda function name with alias for semantic query building.
+                     Configurable to use alternative deployment tiers (e.g., dev1, stage, prod).
 - `SMTP_ADDRESS`
 - `SMTP_PASSWORD`
 - `SMTP_PORT`
 - `SMTP_USER`
 
 ## Optional Environment Variables (all ENVs)
 
+- `AWS_SESSION_TOKEN`: AWS session token for temporary credentials when using expiring AWS credentials
 - `OPENSEARCH_LOG` if `true`, verbosely logs OpenSearch queries.
 
   ```text
   NOTE: do not set this ENV at all if you want ES logging fully disabled.
   Setting it to `false` is still setting it and you will be annoyed and
   confused.
   ```
-
 - `OPENSEARCH_SOURCE_EXCLUDES` comma separated list of fields to exclude from the OpenSearch `_source` field. Leave unset to return all fields.
   - recommended value: `embedding_full_record,fulltext`
 - `PLATFORM_NAME`: The value set is added to the header after the MIT Libraries logo. The logic and CSS for this comes from our theme gem.

app/graphql/types/query_type.rb

@@ -66,6 +66,8 @@ def record_id(id:, index:)
       argument :boolean_type, String, required: false, default_value: 'OR',
                                       description: 'How to join multiword queries. Defaults to "OR" which means any ' \
                                                    'of the words much match. Options include: "OR", "AND"'
+      argument :query_mode, String, required: false, default_value: 'keyword',
+                                    description: 'Search mode, either "keyword" or "semantic"'
 
       # applied filters
       argument :access_to_files_filter, [String],
@@ -103,11 +105,11 @@ def record_id(id:, index:)
     end
 
     def search(searchterm:, citation:, contributors:, funding_information:, geodistance:, geobox:, identifiers:,
-               locations:, subjects:, title:, index:, source:, from:, boolean_type:, fulltext:, per_page: 20, **filters)
+               locations:, subjects:, title:, index:, source:, from:, boolean_type:, fulltext:, per_page: 20, query_mode: 'keyword', **filters)
       query = construct_query(searchterm, citation, contributors, funding_information, geodistance, geobox, identifiers,
-                              locations, subjects, title, source, boolean_type, filters, per_page)
+                              locations, subjects, title, source, boolean_type, filters, per_page, query_mode)
 
-      results = Opensearch.new.search(from, query, Timdex::OSClient, highlight_requested?, index, fulltext)
+      results = Opensearch.new.search(from, query, Timdex::OSClient, highlight: highlight_requested?, index: index, fulltext: fulltext, query_mode: query_mode)
 
       response = {}
       response[:hits] = results['hits']['total']['value']
@@ -135,9 +137,10 @@ def inject_hits_fields_into_source(hits)
     end
 
     def construct_query(searchterm, citation, contributors, funding_information, geodistance, geobox, identifiers,
-                        locations, subjects, title, source, boolean_type, filters, per_page)
+                        locations, subjects, title, source, boolean_type, filters, per_page, query_mode = 'keyword')
       query = {}
       query[:q] = searchterm
+      query[:query_mode] = query_mode
       query[:boolean_type] = boolean_type
       query[:citation] = citation
       query[:contributors] = contributors

app/models/lexical_query_builder.rb

@@ -1,5 +1,5 @@
 class LexicalQueryBuilder
-  def build(params, fulltext = false)
+  def build(params, fulltext: false)
     {
       bool: {
         should: multisearch(params),

app/models/opensearch.rb

@@ -1,13 +1,13 @@
-# rubocop:disable Metrics/ClassLength
 # rubocop:disable Metrics/MethodLength
 class Opensearch
   SIZE = 20
   MAX_SIZE = 200
 
-  def search(from, params, client, highlight = false, index = nil, fulltext = false)
+  def search(from, params, client, highlight: false, index: nil, fulltext: false, query_mode: 'keyword')
     @params = params
     @highlight = highlight
     @fulltext = fulltext?(fulltext)
+    @query_mode = query_mode
     index = default_index unless index.present?
     client.search(index:,
                   body: build_query(from))
@@ -54,8 +54,14 @@ def build_query(from)
 
   # Build the query portion of the elasticsearch json
   def query
-    @query_strategy ||= LexicalQueryBuilder.new
-    @query_strategy.build(@params, @fulltext)
+    builder = case @query_mode
+              when 'semantic'
+                SemanticQueryBuilder.new
+              else
+                LexicalQueryBuilder.new
+              end
+
+    builder.build(@params, fulltext: @fulltext)
   end
 
   def sort_builder

app/models/semantic_query_builder.rb

@@ -0,0 +1,50 @@
+class SemanticQueryBuilder
+  def build(params, fulltext: false)
+    query_text = params[:q].to_s.strip
+
+    # If no query text provided, return a match_all query (consistent with keyword search behavior)
+    return { match_all: {} } if query_text.blank?
+
+    lambda_response = invoke_semantic_builder(query_text)
+    parse_lambda_response(lambda_response)
+  end
+
+  private
+
+  def invoke_semantic_builder(query_text)
+    payload = { query: query_text }
+
+    response = Timdex::LambdaClient.invoke(
+      function_name: ENV.fetch('TIMDEX_SEMANTIC_BUILDER_FUNCTION_NAME'),
+      invocation_type: 'RequestResponse',
+      payload: payload.to_json
+    )
+
+    parse_lambda_payload(response.payload)
+  rescue StandardError => e
+    raise "Semantic query builder Lambda error: #{e.message}"
+  end
+
+  def parse_lambda_payload(payload)
+    # AWS Lambda response payload can be an IO-like object (e.g., StringIO) or a string
+    payload_str = if payload.respond_to?(:read)
+                    payload.read
+                  else
+                    payload.to_s
+                  end
+    JSON.parse(payload_str)
+  rescue JSON::ParserError => e
+    raise "Invalid JSON response from semantic query builder: #{e.message}"
+  end
+
+  def parse_lambda_response(lambda_response)
+    # Lambda returns: { "query": { "bool": { "should": [...] } } }
+    # We extract and return just the inner query object
+    raise "Invalid semantic query builder response: missing 'query' key" unless lambda_response.key?('query')
+
+    query = lambda_response['query']
+    raise 'Invalid semantic query builder response: query must be a Hash' unless query.is_a?(Hash)
+
+    query
+  end
+end

config/initializers/lambda.rb

@@ -0,0 +1,11 @@
+require 'aws-sdk-lambda'
+
+def configure_lambda_client
+  Aws::Lambda::Client.new(
+    region: ENV.fetch('AWS_REGION', 'us-east-1'),
+    access_key_id: ENV.fetch('AWS_ACCESS_KEY_ID'),
+    secret_access_key: ENV.fetch('AWS_SECRET_ACCESS_KEY')
+  )
+end
+
+Timdex::LambdaClient = configure_lambda_client

config/initializers/opensearch.rb

@@ -15,20 +15,20 @@ def os_client
 def aws_os_client
   OpenSearch::Client.new log: ENV.fetch('OPENSEARCH_LOG', false), url: ENV['OPENSEARCH_URL'] do |config|
     # personal keys use expiring credentials with tokens
-    if ENV.fetch('AWS_OPENSEARCH_SESSION_TOKEN', false)
+    if ENV['AWS_SESSION_TOKEN'].present?
       config.request :aws_sigv4,
                       service: 'es',
                       region: ENV['AWS_REGION'],
-                      access_key_id: ENV['AWS_OPENSEARCH_ACCESS_KEY_ID'],
-                      secret_access_key: ENV['AWS_OPENSEARCH_SECRET_ACCESS_KEY'],
-                      session_token: ENV['AWS_OPENSEARCH_SESSION_TOKEN']
+                      access_key_id: ENV['AWS_ACCESS_KEY_ID'],
+                      secret_access_key: ENV['AWS_SECRET_ACCESS_KEY'],
+                      session_token: ENV['AWS_SESSION_TOKEN']
     # application keys don't use tokens
     else
       config.request :aws_sigv4,
                       service: 'es',
                       region: ENV['AWS_REGION'],
-                      access_key_id: ENV['AWS_OPENSEARCH_ACCESS_KEY_ID'],
-                      secret_access_key: ENV['AWS_OPENSEARCH_SECRET_ACCESS_KEY']
+                      access_key_id: ENV['AWS_ACCESS_KEY_ID'],
+                      secret_access_key: ENV['AWS_SECRET_ACCESS_KEY']
     end
   end
 end