This repository was archived by the owner on Mar 4, 2020. It is now read-only.
Fix logic around adding operations already in queue#417
Open
jonbrooks wants to merge 1 commit into
Open
Conversation
…d time would attempt to add it a second time to the NSOperationQueue, and throw an exception.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If an operation was enqueued that was already in the queue, there was logic in place to detect if it was already in the queue and add any new handlers to the existing one, but then the operation could be added to the queue anyway. This could trigger an exception in NSOperationQueue.