revise release note, don't transform output coords

Author: wpbonelli

doc/ReleaseNotes/develop.tex

@@ -32,7 +32,7 @@
 		\item An array out of bounds error for Z-displacement output in inactive cells has been fixed in the CSUB package. Depending on the combination of platform and compiler used to build the program, this could result in crashes.
 		\item Initialize a few uninitialized variables in the CSUB package. Depending on the combination of platform and compiler used to build the program, this could result in different program behaviour.
 		\item Add a warning if saving convergence data for the CSUB package when delay beds are not included in a simulation. Also modified the convergence output data so that it is clear that DVMAX and DSTORAGEMAX data and locations are not calculated in this case (by writing `-\,-' to the output file). 
-		\item Previously the PRT model's PRP package required release points to be specified in the model coordinate system (except for the z coordinate via the LOCAL\_Z option). PRT also previously reported pathlines in the model coordinate system. The PRT model now supports coordinate transformations for release point input and pathline output via keyword options for the PRP package, while preserving the existing default model coordinate system. Release point x and y coordinates may now be specified for structured grids with reference to the local rectilinear cell (with coordinates scaled to the unit interval) via the LOCAL\_XY keyword option. The LOCAL\_XY\_OFFSET option, supported for structured or unstructured grids, can be used to locate release point x and y coordinates at an offset from the cell center (with no distance rescaling). A development option DEV\_GLOBAL\_XY is also provided, enabling transformation of release points from (and pathline points to) the global coordinate system for georeferenced grids.
+		\item Previously the PRT model's PRP package required release points to be specified in the model coordinate system (except for the z coordinate via the LOCAL\_Z option). PRT also previously reported pathlines in the model coordinate system. The PRT model now supports coordinate transformations for release point input and pathline output via keyword options for the PRP package, while preserving the existing default model coordinate system. Release point x and y coordinates may now be specified for structured grids with reference to the local rectilinear cell (with coordinates scaled to the unit interval) via the LOCAL\_XY keyword option. The LOCAL\_XY\_OFFSET option, supported for structured or unstructured grids, can be used to locate release point x and y coordinates at an offset from the cell center (with no distance rescaling).
 	%	\item xxx
 	\end{itemize}
 

src/Model/ParticleTracking/prt-prp.f90

@@ -84,7 +84,6 @@ module PrtPrpModule
     procedure :: read_dimensions => prp_read_dimensions
     procedure :: prp_read_packagedata
     procedure :: release
-    procedure :: get_release_time
     procedure, public :: bnd_obs_supported => prp_obs_supported
     procedure, public :: bnd_df_obs => prp_df_obs
   end type PrtPrpType
@@ -393,12 +392,12 @@ subroutine release(this, ip, trelease)
     integer(I4B) :: irow, icol, ilay, icpl
     integer(I4B) :: ic, icu
     integer(I4B) :: i, j, k
+    integer(I4B) :: icoords
     integer(I4B) :: np
     real(DP) :: x, y, z, xout, yout, zout
     real(DP) :: top, bot, hds
     real(DP), allocatable :: polyverts(:, :)
-    character(len=LINELENGTH) :: errmsg
-    type(ParticleType), pointer :: particle !< particle
+    type(ParticleType), pointer :: particle
 
     ! Increment particle release count
     np = this%nparticles + 1
@@ -409,12 +408,14 @@ subroutine release(this, ip, trelease)
     icu = this%dis%get_nodeuser(ic)
 
     ! Load x/y coordinates and transform if needed
+    icoords = 0
     x = this%rptx(ip)
     y = this%rpty(ip)
     if (this%icoords == 1 .and. ( &
         this%dis%angrot /= DZERO .or. &
         this%dis%xorigin /= DZERO .or. &
         this%dis%yorigin /= DZERO)) then
+      icoords = 1
       ! Transform x and y from global to model coordinates
       call transform(x, y, z, &
                      xout, yout, zout, &
@@ -535,7 +536,7 @@ subroutine release(this, ip, trelease)
     particle%ifrctrn = this%ifrctrn
     particle%iexmeth = this%iexmeth
     particle%iextend = this%iextend
-    particle%icoords = this%icoords
+    particle%icoords = icoords
     particle%extol = this%extol
 
     ! Save particle to the particle store

src/Solution/ParticleTracker/Particle.f90

@@ -79,7 +79,7 @@ module ParticleModule
     integer(I4B), dimension(:), pointer, public, contiguous :: iprp !< index of release package the particle originated in
     integer(I4B), dimension(:), pointer, public, contiguous :: irpt !< index of release point in the particle release package the particle originated in
     ! options
-    integer(I4B), dimension(:), pointer, public, contiguous :: icoords !< coordinate system to use (0: global, 1: model)
+    integer(I4B), dimension(:), pointer, public, contiguous :: icoords !< coordinate system to use (0: model, 1: global)
     integer(I4B), dimension(:), pointer, public, contiguous :: iexmeth !< method for iterative solution of particle exit location and time in generalized Pollock's method
     integer(I4B), dimension(:), pointer, public, contiguous :: iextend !< whether to extend tracking beyond the end of the simulation
     integer(I4B), dimension(:), pointer, public, contiguous :: ifrctrn !< force ternary method