Skip to content

fix(exg): trap multiple connections per cell pair#2757

Open
wpbonelli wants to merge 4 commits into
MODFLOW-ORG:developfrom
wpbonelli:exg-trap-mult-conn
Open

fix(exg): trap multiple connections per cell pair#2757
wpbonelli wants to merge 4 commits into
MODFLOW-ORG:developfrom
wpbonelli:exg-trap-mult-conn

Conversation

@wpbonelli
Copy link
Copy Markdown
Member

@wpbonelli wpbonelli commented Apr 8, 2026

Warn if any pair of connected cells in a like-model exchange has multiple connections. This will be an error for PRT-PRT exchanges, but multiple connections are tolerated for other models for flexibility.


Checklist of items for pull request

  • Replaced section above with description of pull request
  • Added new test or modified an existing test
  • Ran ruff on new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.
  • Formatted new and modified Fortran source files with fprettify
  • Added doxygen comments to new and modified procedures
  • Updated develop.toml with a plain-language description of the bug fix, change, feature; required for changes that may affect users
  • Updated input and output guide
  • Removed checklist items not relevant to this pull request

@wpbonelli wpbonelli added this to the 6.7.1 milestone Apr 8, 2026
@wpbonelli wpbonelli added the bug label Apr 8, 2026
@wpbonelli wpbonelli requested a review from mjr-deltares April 10, 2026 14:39
@wpbonelli wpbonelli marked this pull request as ready for review April 10, 2026 15:25
@wpbonelli wpbonelli requested a review from aprovost-usgs April 16, 2026 12:53
@wpbonelli
Copy link
Copy Markdown
Member Author

Re: deciding whether this should be a general restriction or only apply in some cases, @mjr-deltares figured that people may be using DISU in nonstandard ways involving multiple connections between the same two cells. E.g.

90% of the shared face has a low conductivity and the 10% has a high conductivity to model some kind of geological feature or artifact from mining

@aprovost-usgs
Copy link
Copy Markdown
Contributor

Re: deciding whether this should be a general restriction or only apply in some cases, @mjr-deltares figured that people may be using DISU in nonstandard ways involving multiple connections between the same two cells. E.g.

90% of the shared face has a low conductivity and the 10% has a high conductivity to model some kind of geological feature or artifact from mining

Guess it comes down to whether the risk of a problem due to accidentally duplicative connections going unnoticed outweighs the benefit for creative modeling like @mjr-deltares described. Maybe consider a warning?

@wpbonelli
Copy link
Copy Markdown
Member Author

Maybe consider a warning?

Switched to a warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants