Petsc 3.25 upgrade#2781
Draft
Manangka wants to merge 23 commits into
Draft
Conversation
…to trigger a new 3.25 build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the changes needed to get MODFLOW working with the latest petsc version.
How to build
To build petsc i used the following build.py
The commands to build are:
This will create an out of build install at
c/dev/externals/petsc/install/arch-mswin-icxGet it working with PKG CONFIG
After running the make install command the files are placed at what you have defined at
prefix.The pkg config configuration file is located at ${prefix}\lib\pkgconfig\PETSc.pc.
For the windows build this needs to be updated. The reason for this is that the windows build uses cygwin to build petsc.
/cygdrive/c/byC:/At the PETSc.pc location to the PKG_CONFIG_PATH environment variable
For pkg config to be able to find petsc the location of the PETSc.pc file needs to be added to PKG_CONFIG_PATH environment variable. On windows this can be done at System Properties ->Advanced->Environment Variables
Then create or update the PKG_CONFIG_PATH with the location
An overview of the changes are:
pixi.toml
meson
Fortran
flag%v == KSP_CONVERGED_ITERATING%v-Some of the methods have been renamed e.g.
VecGetArrayReadF90->VecGetArrayReadPCShellGetContextarguments is not available. The solution is to use the petsc macro directly and call it's c counterpartPetscBoolThings that still need to be figures out:
The pipeline needs to be updated. To work with the new meson pkg_config approach this also means that the PETSc.px need to be updated and added to the PKG_CONFIG_PATH variableThis PR has only be tested on a windows system with the IFX compiler. More work may be needed on other systems/compilersChecklist of items for pull request
ruffon new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.fprettifyFor additional information see instructions for contributing and instructions for developing.