refactor: consolidate package class#103
Draft
wpbonelli wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge
PackageBase/ListPackage/ArrayPackage/ScalarPackage/AdvancedPackageinto a singlePackageclass, which builds whatever combination of scalar/array/list variables a given package type needs at init time. Keep old subclasses as aliases toPackagefor compatibility, but show aDeprecationWarningwhen used. Drop thepackage_factorymechanism. Generic variable access/assignment continues to go through__getattr__/__setattr__. Keep explicit properties forstress_period_data,packagedata,maxbound,nbound,rhs, andhcof, set toNonefor inapplicable packages. Variables not catalogued in[adv_]pkgvarsstill useget_advanced_var/set_advanced_var.No behavior changes, pure refactor. Idea is to simplify the object model and reflect the fact that packages may be composites of multiple variable types, rather than collections of just one variable type.