fix(apisimulation.py): fix exchange-related bugs#99
Merged
Conversation
Three independent bugs in ApiSimulation: - __repr__ silently dropped the exchanges section (missing `s +=`). - get_exchange(None) iterated `self._exchanges` (a dict) unpacking each key into two variables, which raises rather than returning an exchange. - The exchange-construction loop in ApiSimulation.load iterated the just-created empty `exchanges` dict instead of `exchange_names`, so `exchanges`/`get_exchange()` never returned a populated ApiExchange for any multi-model (GWF-GWF/GWT-GWT) simulation. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__repr__silently dropped the exchanges section (missings +=)get_exchange(None)failed to return the first detected exchangeApiSimulation.loaditerated the just-created emptyexchangesdict instead ofexchange_names, soexchangesandget_exchange()never returned a real exchange