Switch from MpasConfigParser to tranche config parser#1116
Merged
Conversation
xylar
force-pushed
the
switch-to-tranche-config-parser
branch
from
91b9715 to
d2b8db3
Compare
Collaborator
Author
|
I'll test this in combination with #1115 |
The main advantage of tranche is just that it's a standalone repo so packages can use it without needing MPAS-Tools but it also provides more testing and some additional functionality beyond the MpasConfigParser like interpolation of enviornment variables.
xylar
force-pushed
the
switch-to-tranche-config-parser
branch
from
d2b8db3 to
f5effb5
Compare
This is more convenient for expressions that may involve numpy.
xylar
force-pushed
the
switch-to-tranche-config-parser
branch
from
6eb889b to
84dd087
Compare
Collaborator
Author
TestingThe results of the developer test suite look good. They are here: Update: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main advantage of tranche is just that it's a standalone repo so packages can use it without needing MPAS-Tools but it
also provides more testing and some additional functionality beyond the
MpasConfigParserlike interpolation of environment variables.Checklist
Testingcomment in the PR documents testing used to verify the changes