Skip to content

Commit 3f6d870

Browse files
committed
Merge branch 'mp_thompson_cldfra' into hotfix-v8.0.2 (PR #1153)
This merge fixes a bug when calling the Thompson parameterization of the cloud fraction. The input to the Thompson scheme expects the grid scale to be in units of km, but in the mpas_atmphys_driver_cloudiness module, dx_p was in units of meters. The unit of dx_p has been corrected to be in kilometers. Acknowledgements: Thanks to Brett Wilt for first identifying the bug in the units of dx_p in the call to the Thompson cloud fraction scheme. * mp_thompson_cldfra: * In ./src/core_atmosphere/physics/mpas_atmphys_driver_cloudiness.F, corrected the units of the variable dx_p from meters to kilometers (dx_p is used in the Thompson parameterization of the cloud fraction).
2 parents 098e9c2 + 9e1e1b4 commit 3f6d870

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

src/core_atmosphere/physics/mpas_atmphys_driver_cloudiness.F

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,10 @@ module mpas_atmphys_driver_cloudiness
5151
! Laura D. Fowler (laura@ucar.edu) / 2016-07-05.
5252
! * since we removed the local variable radt_cld_scheme from mpas_atmphys_vars.F, now defines radt_cld_scheme
5353
! as a pointer to config_radt_cld_scheme.
54-
! Laura D. Fowler (laura@ucar.edu) / 2917-02-16.
54+
! Laura D. Fowler (laura@ucar.edu) / 2017-02-16.
55+
! * this is a bug fix. dx_p is converted from meters to kilometers prior to calling the thompson parameterization
56+
! of the cloud fraction.
57+
! Laura D. Fowler (laura@ucar.edu) / 2024-03-23.
5558

5659

5760
contains
@@ -119,6 +122,8 @@ subroutine cloudiness_from_MPAS(configs,mesh,diag_physics,sfc_input,its,ite)
119122
do j = jts,jte
120123
do i = its,ite
121124
dx_p(i,j) = len_disp / meshDensity(i)**0.25
125+
!conversion of dx_p from meters to kilometers.
126+
dx_p(i,j) = dx_p(i,j)*0.001
122127
xland_p(i,j) = xland(i)
123128
enddo
124129

0 commit comments

Comments
 (0)