Skip to content

Switch CI from miniconda to micromamba#620

Merged
xylar merged 2 commits into
MPAS-Dev:masterfrom
altheaden:ci-switch-to-micromamba
Apr 12, 2025
Merged

Switch CI from miniconda to micromamba#620
xylar merged 2 commits into
MPAS-Dev:masterfrom
altheaden:ci-switch-to-micromamba

Conversation

@altheaden
Copy link
Copy Markdown
Collaborator

This PR switches CI to use the setup-micromamba GitHub action instead of the setup-miniconda GitHub action, in an effort to fix CI crashes caused by the latest miniconda version.

@altheaden altheaden added the ci Changes that affect github actions CI label Apr 11, 2025
@altheaden altheaden requested a review from xylar April 11, 2025 21:26
@altheaden
Copy link
Copy Markdown
Collaborator Author

@xylar Considering the recent changes to remove sphinx-multiversion, is there anything else we should update in the docs workflow? I imagine we want to remove it from the list of packages to install during the environment setup at least.

@xylar
Copy link
Copy Markdown
Collaborator

xylar commented Apr 11, 2025

@altheaden, I think I did remove sphinx-multiversion:
https://github.com/MPAS-Dev/MPAS-Tools/pull/617/files
Did I miss somewhere?

@xylar
Copy link
Copy Markdown
Collaborator

xylar commented Apr 11, 2025

Oh, I see. yes, it needs to be removed.

Comment thread .github/workflows/build_workflow.yml Outdated
sphinx sphinx-multiversion mock sphinx_rtd_theme
conda install -y -c ${CONDA_PREFIX}/conda-bld/ \
mpas_tools python=${{ matrix.python-version }} \
sphinx sphinx-multiversion mock sphinx_rtd_theme
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated to match:
https://github.com/MPAS-Dev/MPAS-Tools/blob/master/conda_package/dev-spec.txt#L37-L39

Suggested change
sphinx sphinx-multiversion mock sphinx_rtd_theme
sphinx mock sphinx_rtd_theme

@altheaden
Copy link
Copy Markdown
Collaborator Author

@xylar I think I must have re-introduced it when I was rebasing onto your newest changes. I'll take care of it.

@xylar
Copy link
Copy Markdown
Collaborator

xylar commented Apr 11, 2025

No, I think I just missed it.

@altheaden
Copy link
Copy Markdown
Collaborator Author

Ah, yeah, I see what happened now. There's a call to it at the very end of the workflow where we build the docs to check for issues. Should I just remove the whole job or replace that call with something else?

- if: ${{ steps.skip_check.outputs.should_skip != 'true' }}
name: Build Sphinx Docs
run: |
# sphinx-multiversion expects at least a "master" branch
git branch master || echo "branch master already exists."
cd conda_package/docs
sphinx-multiversion . _build/html

@xylar
Copy link
Copy Markdown
Collaborator

xylar commented Apr 11, 2025

Oops, I didn't realize which workflow this was. That last docs build command needs to be the same as in the documentation:

cd conda_package/docs
DOCS_VERSION=master make versioned-html

@xylar
Copy link
Copy Markdown
Collaborator

xylar commented Apr 11, 2025

Or maybe we can just make master be test instead, since that seems more truthful.

@altheaden altheaden force-pushed the ci-switch-to-micromamba branch from 964681c to ee60eab Compare April 11, 2025 22:36
@altheaden
Copy link
Copy Markdown
Collaborator Author

@xylar How does this look?

- if: ${{ steps.skip_check.outputs.should_skip != 'true' }}
name: Build Sphinx Docs
run: |
cd conda_package/docs
DOCS_VERSION=test make versioned-html

Copy link
Copy Markdown
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly. That looks good!

@xylar xylar self-assigned this Apr 12, 2025
@xylar xylar merged commit 57c6094 into MPAS-Dev:master Apr 12, 2025
6 checks passed
@altheaden altheaden deleted the ci-switch-to-micromamba branch April 14, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Changes that affect github actions CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants