Fix the barotropic streamfunction calculation#621
Merged
Conversation
The fix involves:
* detecting boundary edges
* finding all the unique loops for each continent or island
* finding a unique list of pairs (excluding the edge that
would close the loop
* creating a sparse matrix with:
* A Poisson equation for the BSF in terms of the vertically
integrated vorticity at each vertex
* Adding a constraint on each pair of boundary vertices found
above ensuring that their values are equal
* Adding a constraint that the BSF at the first vertext is
zero
* Adding the transpose of these boundary conditions so that
the matrix is square
* the right-hand side involves the vertically integrated vorticity
and zeros for the boundary conditions
* the solution involves the BSF and a Lagrange multiplier (dropped)
for each boundary condition
Collaborator
Author
|
I'm now seeing constant values along boundaries in ParaView in cases that didn't have them before the fix. I'll post MPAS-Analysis plots once I have them. |
1 task
Collaborator
Author
|
This worked as expected in testing in MPAS-Dev/MPAS-Analysis#1074. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix involves:
would close the loop
integrated vorticity at each vertex
above ensuring that their values are equal
zero
the matrix is square
and zeros for the boundary conditions
for each boundary condition