refactor(serilog-sink): modernize to C# 14 with batch writes and new README

Author: MPCoreDeveloper

src/SharpCoreDB.Serilog.Sinks/CHANGELOG.md

@@ -5,7 +5,34 @@ All notable changes to SharpCoreDB.Serilog.Sinks will be documented in this file
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [1.0.0] - 2025-01-XX
+## [1.0.7] - 2025-06-02
+
+### Changed
+- **BREAKING**: `SharpCoreDBSink` is now `sealed` — prevents unintended inheritance
+- **PERF**: Replaced per-event `ExecuteSQLAsync` loop with `ExecuteBatchSQLAsync` which routes through `InsertBatch` for direct storage engine writes
+- **PERF**: Cached INSERT SQL prefix to avoid repeated string interpolation per event
+- **PERF**: `StringBuilder` initialized with capacity hint to reduce resizing in hot path
+- **SAFETY**: Added `Flush()` call after batch writes to ensure data persistence to disk
+- **SAFETY**: Thread-safe table creation using C# 14 `Lock` class with double-check pattern
+- **SAFETY**: Added `ConfigureAwait(false)` on all async calls for library deadlock prevention
+- **C# 14**: Raw string literals for multi-line CREATE TABLE SQL
+- **C# 14**: Collection expressions (`List<string> statements = []`)
+- **C# 14**: `Lock` class instead of `object` for synchronization
+- Used `ArgumentException.ThrowIfNullOrWhiteSpace` for parameter validation
+- Improved XML documentation with `<see cref="..."/>` cross-references
+
+### Removed
+- Unnecessary finalizer (`~SharpCoreDBSink`) — class holds no unmanaged resources
+- Simplified `Dispose` pattern for sealed class (no `Dispose(bool)` needed)
+- Removed `BeginBatchUpdate`/`EndBatchUpdate`/`CancelBatchUpdate` calls — `ExecuteBatchSQLAsync` handles transactions internally
+
+### Fixed
+- `_tableCreated` field was not thread-safe — now protected by `Lock` with double-check pattern
+- Missing `Flush()` after writes could cause data loss on crash
+- Missing `ConfigureAwait(false)` could deadlock in synchronization contexts
+- Replaced manual `throw new ArgumentException` with `ArgumentException.ThrowIfNullOrWhiteSpace`
+
+## [1.0.0] - 2025-01-28
 
 ### Added
 - Initial release of SharpCoreDB.Serilog.Sinks

src/SharpCoreDB.Serilog.Sinks/LoggerConfigurationExtensions.cs

@@ -6,10 +6,13 @@
 using SharpCoreDB.Interfaces;
 using SharpCoreDB.Services;
 using Microsoft.Extensions.DependencyInjection;
+
 namespace SharpCoreDB.Serilog.Sinks;
-/// Michel Posseth 
+
+/// Michel Posseth
 /// <summary>
 /// Extension methods for configuring the SharpCoreDB sink with Serilog.
+/// Provides three overloads: database instance, connection string, and options object.
 /// </summary>
 public static class LoggerConfigurationExtensions
 {
@@ -39,7 +42,6 @@ public static LoggerConfiguration SharpCoreDB(
         string storageEngine = "AppendOnly")
     {
         ArgumentNullException.ThrowIfNull(loggerSinkConfiguration);
-
         ArgumentNullException.ThrowIfNull(database);
 
         var actualPeriod = period ?? DefaultPeriod;
@@ -65,6 +67,7 @@ public static LoggerConfiguration SharpCoreDB(
 
     /// <summary>
     /// Writes log events to a SharpCoreDB database using a connection string.
+    /// Creates a database instance internally with logging-optimized configuration.
     /// </summary>
     /// <param name="loggerSinkConfiguration">The logger sink configuration.</param>
     /// <param name="path">The path to the .scdb file.</param>
@@ -90,22 +93,14 @@ public static LoggerConfiguration SharpCoreDB(
         IServiceProvider? serviceProvider = null)
     {
         ArgumentNullException.ThrowIfNull(loggerSinkConfiguration);
-
-        if (string.IsNullOrWhiteSpace(path))
-        {
-            throw new ArgumentException("Path cannot be null or whitespace.", nameof(path));
-        }
-
-        if (string.IsNullOrWhiteSpace(password))
-        {
-            throw new ArgumentException("Password cannot be null or whitespace.", nameof(password));
-        }
+        ArgumentException.ThrowIfNullOrWhiteSpace(path);
+        ArgumentException.ThrowIfNullOrWhiteSpace(password);
 
         // Create or use provided service provider
         var services = serviceProvider ?? CreateDefaultServiceProvider();
         var factory = services.GetRequiredService<DatabaseFactory>();
-        
-        // Create database with optimized config for logging
+
+        // Create database with config optimized for logging workloads
         var config = new DatabaseConfig
         {
             EnableQueryCache = false, // Logs are typically write-once
@@ -131,7 +126,7 @@ public static LoggerConfiguration SharpCoreDB(
     }
 
     /// <summary>
-    /// Writes log events to a SharpCoreDB database using options.
+    /// Writes log events to a SharpCoreDB database using an options object.
     /// </summary>
     /// <param name="loggerSinkConfiguration">The logger sink configuration.</param>
     /// <param name="options">The sink options.</param>
@@ -141,10 +136,9 @@ public static LoggerConfiguration SharpCoreDB(
         SharpCoreDBSinkOptions options)
     {
         ArgumentNullException.ThrowIfNull(loggerSinkConfiguration);
-
         ArgumentNullException.ThrowIfNull(options);
 
-        if (options.Database != null)
+        if (options.Database is not null)
         {
             return SharpCoreDB(
                 loggerSinkConfiguration,

src/SharpCoreDB.Serilog.Sinks/PROJECT_SUMMARY.md

@@ -6,7 +6,7 @@ A production-ready Serilog sink for SharpCoreDB, providing efficient batch loggi
 
 ## Key Features
 
-* **Efficient Batching**: Uses Serilog.Sinks.PeriodicBatching for optimal performance
+* **Efficient Batching**: Uses `ExecuteBatchSQLAsync` → `InsertBatch` for optimal storage engine throughput
 * **Encrypted Storage**: Leverages SharpCoreDB's AES-256-GCM encryption
 * **High Performance**: 10,000+ logs/second capability
 * **ULID Primary Keys**: Sortable, timestamp-based unique identifiers
@@ -31,9 +31,9 @@ SharpCoreDB.Serilog.Sinks/
 ## Technology Stack
 
 * **.NET 10**: Latest .NET platform
-* **C# 12+**: Modern C# features
-* **Serilog 4.2.0**: Structured logging
-* **Serilog.Sinks.PeriodicBatching 5.0.0**: Batch processing
+* **C# 14**: Modern C# features (Lock class, raw string literals, collection expressions)
+* **Serilog 4.x**: Structured logging
+* **Serilog.Sinks.PeriodicBatching 5.x**: Batch processing
 * **SharpCoreDB**: Encrypted database backend
 
 ## Database Schema
@@ -53,9 +53,10 @@ CREATE TABLE Logs (
 
 * **Write Throughput**: 10,000+ logs/second
 * **Batch Latency**: Sub-millisecond per batch
-* **Memory Usage**: Minimal footprint
+* **Memory Usage**: Minimal footprint (cached INSERT prefix, capacity-hinted StringBuilder)
 * **Storage Overhead**: Efficient with compression
 * **Encryption Overhead**: Near-zero with AES-NI
+* **Thread Safety**: C# 14 `Lock` class with double-check pattern for table init
 
 ## Configuration Options