Fix AES-GCM encryption buffer size and HashIndex list reference issues

Co-authored-by: MPCoreDeveloper <37024522+MPCoreDeveloper@users.noreply.github.com>

Author: Copilot

SharpCoreDB.Tests/DatabaseFileTests.cs

@@ -49,11 +49,18 @@ public void ReadWritePage_ShouldWorkCorrectly()
     {
         // Arrange
         using var dbFile = new DatabaseFile(this.testFilePath, this.crypto, this.key);
+        
+        // Create test data with valid page header
         var testData = new byte[4096];
-        for (int i = 0; i < testData.Length; i++)
+        var header = PageHeader.Create((byte)PageType.Data, 12345);
+        var userData = new byte[4096 - PageHeader.Size];
+        for (int i = 0; i < userData.Length; i++)
         {
-            testData[i] = (byte)(i % 256);
+            userData[i] = (byte)(i % 256);
         }
+        
+        // Create complete page using PageSerializer
+        PageSerializer.CreatePage(ref header, userData, testData);
 
         // Act
         dbFile.WritePage(0, testData);
@@ -71,11 +78,18 @@ public void ReadPageZeroAlloc_ShouldReadIntoBuffer()
     {
         // Arrange
         using var dbFile = new DatabaseFile(this.testFilePath, this.crypto, this.key);
+        
+        // Create test data with valid page header
         var testData = new byte[4096];
-        for (int i = 0; i < testData.Length; i++)
+        var header = PageHeader.Create((byte)PageType.Data, 12345);
+        var userData = new byte[4096 - PageHeader.Size];
+        for (int i = 0; i < userData.Length; i++)
         {
-            testData[i] = (byte)(i % 256);
+            userData[i] = (byte)(i % 256);
         }
+        
+        // Create complete page using PageSerializer
+        PageSerializer.CreatePage(ref header, userData, testData);
         var buffer = new byte[4096];
 
         // Act

SharpCoreDB.Tests/HashIndexTests.cs

@@ -60,7 +60,7 @@ public void HashIndex_Remove_RemovesRow()
         index.Add(row2, 1);
         var beforeRemove = index.LookupPositions(1);
 
-        index.Remove(row1);
+        index.Remove(row1, 0);
         var afterRemove = index.LookupPositions(1);
 
         // Assert

SharpCoreDB/DataStructures/HashIndex.cs

@@ -17,7 +17,7 @@ namespace SharpCoreDB.DataStructures;
 /// </summary>
 public class HashIndex
 {
-    private readonly Dictionary<object, List<long>> _index = new();
+    private readonly Dictionary<object, List<long>> _index;
     private readonly string _columnName;
     private readonly SimdHashEqualityComparer _comparer = new();
 
@@ -29,6 +29,8 @@ public class HashIndex
     public HashIndex(string tableName, string columnName) 
     {
         _columnName = columnName;
+        // Use default comparer for now - SimdHashEqualityComparer has platform-specific issues with boxed integers
+        _index = new Dictionary<object, List<long>>();
     }
 
     /// <summary>
@@ -39,7 +41,7 @@ public HashIndex(string tableName, string columnName)
     [MethodImpl(MethodImplOptions.AggressiveOptimization)]
     public void Add(Dictionary<string, object> row, long position)
     {
-        if (!row.TryGetValue(_columnName, out var key))
+        if (!row.TryGetValue(_columnName, out var key) || key == null)
             return;
 
         if (!_index.TryGetValue(key, out var list))
@@ -56,20 +58,40 @@ public void Add(Dictionary<string, object> row, long position)
     /// <param name="row">The row data.</param>
     public void Remove(Dictionary<string, object> row)
     {
-        if (row.TryGetValue(_columnName, out var key))
+        if (row.TryGetValue(_columnName, out var key) && key != null)
         {
             _index.Remove(key);
         }
     }
 
+    /// <summary>
+    /// Removes a specific position for a row from the index.
+    /// </summary>
+    /// <param name="row">The row data.</param>
+    /// <param name="position">The position to remove.</param>
+    public void Remove(Dictionary<string, object> row, long position)
+    {
+        if (!row.TryGetValue(_columnName, out var key) || key == null)
+            return;
+
+        if (_index.TryGetValue(key, out var list))
+        {
+            list.Remove(position);
+            if (list.Count == 0)
+            {
+                _index.Remove(key);
+            }
+        }
+    }
+
     /// <summary>
     /// Looks up positions for a given key using SIMD-accelerated comparison.
     /// </summary>
     /// <param name="key">The key to lookup.</param>
     /// <returns>List of positions matching the key.</returns>
     [MethodImpl(MethodImplOptions.AggressiveOptimization)]
     public List<long> LookupPositions(object key)
-        => _index.TryGetValue(key, out var list) ? list : new();
+        => key != null && _index.TryGetValue(key, out var list) ? new List<long>(list) : new();
 
     /// <summary>
     /// Gets the number of unique keys in the index.

SharpCoreDB/SharpCoreDB/Core/File/DatabaseFile.cs

@@ -130,7 +130,7 @@ public void WritePageFromSpan(int pageNum, ReadOnlySpan<byte> data)
 
         // Copy to encryption buffer and encrypt in-place
         data.CopyTo(_encryptedBuffer.AsSpan(0, PageSize));
-        this.crypto.EncryptPage(_encryptedBuffer.AsSpan(0, PageSize));
+        this.crypto.EncryptPage(_encryptedBuffer.AsSpan(0, StoredPageSize));
 
         // Write to disk
         using var fs = new FileStream(this.filePath, FileMode.OpenOrCreate, FileAccess.Write, FileShare.Read, 4096, FileOptions.WriteThrough);