aaarghhh

Author: MPCoreDeveloper

SharpCoreDB.Benchmarks/Comparative/ComparativeInsertBenchmarks.cs

@@ -368,20 +368,23 @@ public void SQLite_File_WAL_FullSync_BulkInsert()
         // FAIR COMPARISON: Configure SQLite with durability equivalent to SharpCoreDB
         // This shows the TRUE performance cost of full durability guarantees
 
-        using var cmd = sqliteFile?.CreateCommand();
-        
-        // Enable WAL mode
-        cmd!.CommandText = "PRAGMA journal_mode = WAL";
-        cmd.ExecuteNonQuery();
-        
-        // CRITICAL: Set synchronous to FULL for equivalent durability to SharpCoreDB FullSync
-        // This forces fsync after each transaction commit (like SharpCoreDB)
-        cmd.CommandText = "PRAGMA synchronous = FULL";
-        cmd.ExecuteNonQuery();
+        // Configure SQLite PRAGMAS BEFORE transaction
+        using (var pragmaCmd = sqliteFile?.CreateCommand())
+        {
+            pragmaCmd!.CommandText = "PRAGMA journal_mode = WAL";
+            pragmaCmd.ExecuteNonQuery();
+            
+            // CRITICAL: Set synchronous to FULL for equivalent durability to SharpCoreDB FullSync
+            // This forces fsync after each transaction commit (like SharpCoreDB)
+            pragmaCmd.CommandText = "PRAGMA synchronous = FULL";
+            pragmaCmd.ExecuteNonQuery();
+        }
 
         var users = dataGenerator.GenerateUsers(RecordCount);
 
         using var transaction = sqliteFile?.BeginTransaction();
+        using var cmd = sqliteFile?.CreateCommand();
+        cmd!.Transaction = transaction;
         cmd.CommandText = @"
             INSERT OR REPLACE INTO users (id, name, email, age, created_at, is_active)
             VALUES (@id, @name, @email, @age, @created_at, @is_active)";

SharpCoreDB.Benchmarks/Comparative/ComparativeSelectBenchmarks.cs

@@ -230,7 +230,28 @@ private void VerifySetup()
             }
             else
             {
-                Console.WriteLine($"  ? SharpCoreDB (Encrypted): Verified (found user ID 1)");
+                // ENHANCED: Validate the data integrity
+                var row = testResults[0];
+                if (!row.ContainsKey("id") || !row.ContainsKey("name") || !row.ContainsKey("email"))
+                {
+                    errors.Add($"SharpCoreDB (Encrypted): Incomplete row data - missing fields");
+                }
+                else if (row["id"] == null || row["id"] == DBNull.Value)
+                {
+                    errors.Add($"SharpCoreDB (Encrypted): ID field is null");
+                }
+                else if ((int)row["id"] != 1)
+                {
+                    errors.Add($"SharpCoreDB (Encrypted): Expected ID 1, got {row["id"]}");
+                }
+                else if (string.IsNullOrEmpty(row["name"]?.ToString()))
+                {
+                    errors.Add($"SharpCoreDB (Encrypted): Name field is empty (data corruption!)");
+                }
+                else
+                {
+                    Console.WriteLine($"  ? SharpCoreDB (Encrypted): Verified (ID={row["id"]}, Name={row["name"]})");
+                }
             }
         }
         catch (Exception ex)
@@ -248,7 +269,28 @@ private void VerifySetup()
             }
             else
             {
-                Console.WriteLine($"  ? SharpCoreDB (No Encryption): Verified (found user ID 1)");
+                // ENHANCED: Validate the data integrity
+                var row = testResults[0];
+                if (!row.ContainsKey("id") || !row.ContainsKey("name") || !row.ContainsKey("email"))
+                {
+                    errors.Add($"SharpCoreDB (No Encryption): Incomplete row data - missing fields");
+                }
+                else if (row["id"] == null || row["id"] == DBNull.Value)
+                {
+                    errors.Add($"SharpCoreDB (No Encryption): ID field is null");
+                }
+                else if ((int)row["id"] != 1)
+                {
+                    errors.Add($"SharpCoreDB (No Encryption): Expected ID 1, got {row["id"]}");
+                }
+                else if (string.IsNullOrEmpty(row["name"]?.ToString()))
+                {
+                    errors.Add($"SharpCoreDB (No Encryption): Name field is empty (data corruption!)");
+                }
+                else
+                {
+                    Console.WriteLine($"  ? SharpCoreDB (No Encryption): Verified (ID={row["id"]}, Name={row["name"]})");
+                }
             }
         }
         catch (Exception ex)

SharpCoreDB.Tests/BufferedWalTests.cs

@@ -1,5 +1,6 @@
 using Microsoft.Extensions.DependencyInjection;
 using System.Diagnostics;
+using SharpCoreDB.Interfaces;
 
 namespace SharpCoreDB.Tests;
 
@@ -12,6 +13,7 @@ public class BufferedWalTests : IDisposable
     private readonly string _testDbPath;
     private readonly IServiceProvider _serviceProvider;
     private readonly DatabaseFactory _factory;
+    private readonly List<IDatabase> _openDatabases = new();
 
     public BufferedWalTests()
     {
@@ -27,10 +29,48 @@ public BufferedWalTests()
 
     public void Dispose()
     {
+        // Dispose all open database instances first
+        foreach (var db in _openDatabases)
+        {
+            try
+            {
+                (db as IDisposable)?.Dispose();
+            }
+            catch
+            {
+                // Ignore errors during disposal
+            }
+        }
+        _openDatabases.Clear();
+
+        // Give OS time to release file handles
+        System.Threading.Thread.Sleep(100);
+
         // Clean up test databases after each test
         if (Directory.Exists(_testDbPath))
         {
-            Directory.Delete(_testDbPath, true);
+            try
+            {
+                Directory.Delete(_testDbPath, true);
+            }
+            catch
+            {
+                // If cleanup fails, try again with retries
+                for (int i = 0; i < 3; i++)
+                {
+                    try
+                    {
+                        System.Threading.Thread.Sleep(100 * (i + 1));
+                        if (Directory.Exists(_testDbPath))
+                            Directory.Delete(_testDbPath, true);
+                        break;
+                    }
+                    catch when (i < 2)
+                    {
+                        // Retry
+                    }
+                }
+            }
         }
     }
 
@@ -40,6 +80,7 @@ public void BufferedWal_BasicOperations_WorksCorrectly()
         // Arrange - Use HighPerformance config with buffered WAL
         var config = DatabaseConfig.HighPerformance;
         var db = _factory.Create(_testDbPath, "testPassword", false, config);
+        _openDatabases.Add(db);
 
         // Act - Create table and perform multiple inserts (should use buffered WAL)
         db.ExecuteSQL("CREATE TABLE test (id INTEGER, name TEXT, value INTEGER)");
@@ -60,14 +101,21 @@ public void BufferedWal_DataPersistence_WorksCorrectly()
 
         // Act - Create database, insert data with buffered WAL
         var db1 = _factory.Create(_testDbPath, "testPassword", false, config);
+        _openDatabases.Add(db1);
         db1.ExecuteSQL("CREATE TABLE data (id INTEGER, value TEXT)");
         for (int i = 0; i < 150; i++)
         {
             db1.ExecuteSQL("INSERT INTO data VALUES (?, ?)", new Dictionary<string, object?> { { "0", i }, { "1", $"value{i}" } });
         }
 
+        // Close first database before opening second
+        (db1 as IDisposable)?.Dispose();
+        _openDatabases.Remove(db1);
+        System.Threading.Thread.Sleep(100);
+
         // Reopen database
         var db2 = _factory.Create(_testDbPath, "testPassword", false, config);
+        _openDatabases.Add(db2);
         db2.ExecuteSQL("SELECT * FROM data WHERE id = '100'");
 
         // Assert - Data persisted correctly with buffered WAL
@@ -84,6 +132,7 @@ public void BufferedWal_LargeBufferSize_WorksCorrectly()
             WalBufferSize = 2 * 1024 * 1024 // 2MB buffer
         };
         var db = _factory.Create(_testDbPath, "testPassword", false, config);
+        _openDatabases.Add(db);
 
         // Act - Perform many inserts that should benefit from large buffer
         db.ExecuteSQL("CREATE TABLE entries (id INTEGER, data TEXT)");
@@ -102,6 +151,7 @@ public void BufferedWal_MixedOperations_WorksCorrectly()
         // Arrange
         var config = DatabaseConfig.HighPerformance;
         var db = _factory.Create(_testDbPath, "testPassword", false, config);
+        _openDatabases.Add(db);
 
         // Act - Mix of different operations
         db.ExecuteSQL("CREATE TABLE mixed (id INTEGER PRIMARY KEY, name TEXT, active BOOLEAN)");
@@ -142,6 +192,7 @@ public void BufferedWal_PerformanceImprovement_IsMeasurable()
         };
 
         var db = _factory.Create(_testDbPath, "testPassword", false, config);
+        _openDatabases.Add(db);
         db.ExecuteSQL("CREATE TABLE perf_test (id INTEGER, data TEXT, value INTEGER)");
 
         // Act - Measure time for bulk inserts

SharpCoreDB.Tests/DdlTests.cs

@@ -37,12 +37,38 @@ public DdlTests()
 
     public void Dispose()
     {
-        this.db.Dispose();
+        try
+        {
+            this.db.Dispose();
+        }
+        catch { }
+
+        // Force garbage collection and wait for finalizers to complete
+        // This ensures all file handles are released before cleanup
+        GC.Collect();
+        GC.WaitForPendingFinalizers();
+        GC.Collect();
+
+        // Wait for file handles to be released before cleanup
+        System.Threading.Thread.Sleep(250);
+
         if (Directory.Exists(this.testDbPath))
         {
             try
             {
-                Directory.Delete(this.testDbPath, recursive: true);
+                // Try to delete with retry logic
+                for (int i = 0; i < 5; i++)
+                {
+                    try
+                    {
+                        Directory.Delete(this.testDbPath, recursive: true);
+                        break;
+                    }
+                    catch when (i < 4)
+                    {
+                        System.Threading.Thread.Sleep(150 * (i + 1));
+                    }
+                }
             }
             catch
             {
@@ -83,7 +109,8 @@ public void DropTable_DeletesDataFile()
         // Act
         this.db.ExecuteSQL("DROP TABLE temp");
 
-        // Assert
+        // Assert - wait for file to be deleted
+        System.Threading.Thread.Sleep(100);
         Assert.False(File.Exists(dataFile), "Data file should be deleted after DROP TABLE");
     }
 
@@ -212,7 +239,8 @@ public void AlterTableRename_RenamesDataFile()
         // Act
         this.db.ExecuteSQL("ALTER TABLE old_name RENAME TO new_name");
 
-        // Assert
+        // Assert - wait for file operations to complete
+        System.Threading.Thread.Sleep(100);
         Assert.False(File.Exists(oldFile), "Old data file should not exist");
         Assert.True(File.Exists(newFile), "New data file should exist");
     }
@@ -303,6 +331,9 @@ public void DDL_DropAndRecreate_Success()
         // Drop table
         this.db.ExecuteSQL("DROP TABLE temp");
 
+        // Wait for file handles to be released - give OS time to close file
+        System.Threading.Thread.Sleep(200);
+
         // Recreate with different schema
         this.db.ExecuteSQL("CREATE TABLE temp (id INTEGER PRIMARY KEY, value INTEGER)");
         this.db.ExecuteSQL("INSERT INTO temp VALUES (1, 42)");