Skip to content

Commit 0b9cfe8

Browse files
Gate the alignment pass in Workflow, Review, PR format, and readiness
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent 2e3fcdb commit 0b9cfe8

4 files changed

Lines changed: 13 additions & 1 deletion

File tree

src/docs/Ways-of-Working/Definition-of-Ready-and-Done.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ A pull request is ready for review when:
3131
- Native dependencies are current and every prerequisite the change relies on has landed; the pull request is not used to bypass a blocked-by edge.
3232
- All required checks are green — not just tests that pass locally. CI is complete, not in progress.
3333
- The automated review loop has converged — a clean [Copilot round](Contribution-Workflow.md#the-copilot-review-loop) with no unresolved review threads.
34+
- The [standards and framework alignment pass](Workflow-Stages/Implement.md#5-standards-and-framework-alignment-pass) has run against the finished change, its result covers every changed surface in the pull request, and every exception links a follow-up issue.
3435
- The title, release-note description, and exactly one change-type label are finalized. See [PR Format](PR-Format.md).
3536

3637
If any item is open, the pull request stays a draft. Marking it ready with known-open work shifts the author's unfinished job onto reviewers — the opposite of what the signal means.

src/docs/Ways-of-Working/PR-Format.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,14 @@ The **Technical details** block is for reviewers and maintainers. Include intern
120120
- Implementation approach and design decisions.
121121
- Backward compatibility notes for developers.
122122
- **Implementation plan progress** — cross-reference the closing Task or Bug's plan. Which plan steps does this PR complete? Which were moved to follow-up delivery issues?
123+
- **Standards and framework alignment** — the result of the [alignment pass](Workflow-Stages/Implement.md#5-standards-and-framework-alignment-pass), as one row per changed surface. The stage procedure owns when and how the pass is run; this block only carries its evidence.
124+
125+
| Changed surface | Standards checked | Framework docs checked | Result |
126+
| --- | --- | --- | --- |
127+
| `src/**` (PowerShell) | Naming, Functions | Module source layout | Aligned |
128+
| `.github/workflows/**` | GitHub Actions | Reusable workflow contract | Exception — Owner/Repo#123 |
129+
130+
A result is `Aligned`, `Fixed in this PR`, or `Exception` with a link to the follow-up issue that carries it.
123131

124132
The **Relevant issues (or links)** block is required and uses fully qualified references (`Owner/Repo#N`) so links work across repositories.
125133

src/docs/Ways-of-Working/Workflow-Stages/Review.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ Check each dimension per [Review Etiquette](../Review-Etiquette.md):
3333
- **Taste** — readability, naming, structure, tests that exercise behaviour.
3434
- **Security** — input validation, no secrets in logs, SHA-pinned actions, least privilege. Escalate a deep pass to [Security Review](Security-Review.md).
3535
- **Documentation** — updated where user-facing behaviour changed.
36+
- **Standards and framework alignment** — the pull request records the author's [alignment pass](Implement.md#5-standards-and-framework-alignment-pass), the result covers every changed surface, and each exception links a real follow-up issue. Spot-check at least one row against the canonical standard or framework page rather than trusting the summary; a missing or hollow pass is a blocking finding.
3637
- **Tests** — new behaviour has tests; bugs get regression tests.
3738

3839
### 4. Post the review
@@ -55,6 +56,7 @@ An approval co-signs the change, so approve once the blocking concerns are resol
5556
## Where this connects
5657

5758
- [Review Etiquette](../Review-Etiquette.md) — tone, severity, and how to disagree well.
59+
- [Implement](Implement.md#5-standards-and-framework-alignment-pass) — the author-side alignment pass this stage verifies.
5860
- [PR Format](../PR-Format.md) — delivery-leaf closure and contextual aggregate links.
5961
- [Branching and Merging](../Branching-and-Merging.md) — who approves and how a change lands.
6062
- [Security Review](Security-Review.md) — the specialized security path.

src/docs/Ways-of-Working/Workflow.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,8 @@ Execute one ready, unblocked Task or Bug. For repository delivery:
111111
3. **Implement** — work through the implementation plan. One logical change per commit. Update the issue as each plan step completes.
112112
4. **Test locally** — don't push known failures to CI. Push work as far inward as it can go.
113113
5. **Self-review with automation** — run the [Copilot review loop](Contribution-Workflow.md#the-copilot-review-loop) until it reports a clean round, fixing in-scope feedback and filing follow-up issues for the rest.
114-
6. **Ready and auto-merge** — when the change meets the [Definition of Ready for Review](Definition-of-Ready-and-Done.md#definition-of-ready-for-review), finalize the pull request per [PR Format](PR-Format.md), mark it ready, and enable auto-merge.
114+
6. **Standards and framework alignment pass** — once the change is complete, reconcile it against process, the applicable [Coding Standards](../Coding-Standards/index.md) chapters, and the repository's framework documentation, and record the result in the pull request. See [Implement](Workflow-Stages/Implement.md#5-standards-and-framework-alignment-pass).
115+
7. **Ready and auto-merge** — when the change meets the [Definition of Ready for Review](Definition-of-Ready-and-Done.md#definition-of-ready-for-review), finalize the pull request per [PR Format](PR-Format.md), mark it ready, and enable auto-merge.
115116

116117
An audited operational Task follows its [operational completion path](Issues/Types/Task.md#operational-delivery) instead of creating a branch or pull request.
117118

0 commit comments

Comments
 (0)