Skip to content

Commit 2e3fcdb

Browse files
Define the standards and framework alignment pass in the Implement stage
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent 7df16fd commit 2e3fcdb

1 file changed

Lines changed: 25 additions & 2 deletions

File tree

src/docs/Ways-of-Working/Workflow-Stages/Implement.md

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,28 @@ When the plan is wrong, stop and document the conflict in a comment, then update
4747
1. Run the [Copilot review loop](../Contribution-Workflow.md#the-copilot-review-loop) until it reports a clean round.
4848
2. Triage each thread and CI failure per [Review Etiquette](../Review-Etiquette.md): fix in scope and propagate the same fix elsewhere; file a follow-up for out-of-scope; reply, then resolve.
4949

50-
### 5. Finalize and hand off
50+
### 5. Standards and framework alignment pass
51+
52+
Run this once per implementation session, when the change is otherwise complete and before the pull request is marked ready — not on every commit. Re-read the applicable guidance in precedence order and reconcile the whole diff against it:
53+
54+
1. **Process** — the [Ways of Working](../index.md) pages that govern this stage, including [Commit Conventions](../Commit-Conventions.md), [PR Format](../PR-Format.md), and [Branching and Merging](../Branching-and-Merging.md).
55+
2. **Standards** — the [Coding Standards](../../Coding-Standards/index.md) chapters that apply to the languages and file types actually changed.
56+
3. **Framework and domain documentation** — the documentation the repository's framework or product owns, such as the module-framework documentation for a module repository or the action contract for an action repository.
57+
58+
Process defines the method; standards and framework documentation define correctness details. Where the layers overlap, the narrower layer supplies the detail and the broader layer supplies the method — a framework page never overrides a process rule it does not own. Read the canonical pages instead of recalling them; that is what keeps guidance written once and referenced everywhere.
59+
60+
Record the outcome as one row per changed surface:
61+
62+
| Changed surface | Standards checked | Framework docs checked | Result |
63+
| --- | --- | --- | --- |
64+
| `src/functions/**` (PowerShell) | Naming, Functions, Error Handling | Module source layout | Aligned |
65+
| `.github/workflows/**` | GitHub Actions | Reusable workflow contract | Exception — Owner/Repo#123 |
66+
67+
A result is `Aligned`, `Fixed in this PR`, or `Exception` with a link that justifies it. Carry the table into the pull request's Technical details block per [PR Format](../PR-Format.md), so [Review](Review.md) can verify the pass instead of guessing whether it happened.
68+
69+
**Stop rule.** Fix what is in scope for the closing Task or Bug and small enough to keep the pull request reviewable. When a finding is out of scope, systemic across the repository, or would change the shape of the pull request, file a follow-up issue through [Define](Define.md), link it in the table as an exception, and leave the change as it is. The pass improves alignment; it does not turn into a second delivery.
70+
71+
### 6. Finalize and hand off
5172

5273
When the change meets the [Definition of Ready for Review](../Definition-of-Ready-and-Done.md):
5374

@@ -60,11 +81,13 @@ When the change meets the [Definition of Ready for Review](../Definition-of-Read
6081
2. Progress is visible — the delivery issue is updated as plan steps complete, not in bulk.
6182
3. Draft pull request from the start; stay in the issue's scope.
6283
4. Mark ready only when the change meets the Definition of Ready for Review — never with open plan steps.
63-
5. Return unplanned work to [Define](Define.md) and hand review-ready work to [Review](Review.md).
84+
5. Run the standards and framework alignment pass once at session end, before marking the pull request ready, and record its result in the pull request.
85+
6. Return unplanned work to [Define](Define.md) and hand review-ready work to [Review](Review.md).
6486

6587
## Where this connects
6688

6789
- [Contribution Workflow](../Contribution-Workflow.md) — the draft-first loop this runs.
90+
- [Coding Standards](../../Coding-Standards/index.md) — the standards layer the alignment pass reconciles against.
6891
- [Issue Lifecycle](../Issues/Process/Lifecycle.md) and [Issue Relationships](../Issues/Process/Relationships.md) — delivery-leaf eligibility and blockers.
6992
- [Definition of Ready and Done](../Definition-of-Ready-and-Done.md) — the gate this hands off at.
7093
- [PR Format](../PR-Format.md) and [Branching and Merging](../Branching-and-Merging.md) — packaging and landing.

0 commit comments

Comments
 (0)