Skip to content

Commit b112655

Browse files
committed
fix: update default status code handling in render response to use 200 when statusCode is null or invalid
1 parent edaff3e commit b112655

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

src/controllers/render-controller/render.controller.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ describe("RenderController", () => {
161161
).rejects.toThrow("Navigation timeout");
162162
});
163163

164-
it("should use default status code 500 when statusCode is null", async () => {
164+
it("should use default status code 200 when statusCode is null", async () => {
165165
const mockRequest: MockRequest = {
166166
url: "/render/https://example.com",
167167
headers: { "user-agent": "test-agent" },
@@ -179,7 +179,7 @@ describe("RenderController", () => {
179179
mockResponse as Response,
180180
);
181181

182-
expect(mockResponse.status).toHaveBeenCalledWith(500);
182+
expect(mockResponse.status).toHaveBeenCalledWith(200);
183183
});
184184

185185
it("should use default status code 200 when statusCode is invalid", async () => {

src/controllers/render-controller/render.controller.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@ export class RenderController {
3030

3131
const result = await this.prerenderService.render(url, reguest.headers);
3232

33-
response
34-
.status(Number.parseInt(result.statusCode ?? "200"))
35-
.send(result.pageContent);
33+
const statusCode = Number.parseInt(result.statusCode ?? "200");
34+
const validStatusCode = Number.isNaN(statusCode) ? 200 : statusCode;
35+
36+
response.status(validStatusCode).send(result.pageContent);
3637
}
3738
}

0 commit comments

Comments
 (0)