[DOP-25498] Do not restrict values of Job.type#205
Merged
Conversation
67a37d5 to
6810b73
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #205 +/- ##
===========================================
- Coverage 91.99% 91.83% -0.17%
===========================================
Files 201 205 +4
Lines 5033 5092 +59
Branches 354 364 +10
===========================================
+ Hits 4630 4676 +46
- Misses 328 336 +8
- Partials 75 80 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6810b73 to
2c0dee9
Compare
2c0dee9 to
45bce6b
Compare
TiGrib
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
JobTypeenum has hard-coded values likeSPARK_APPLICATIONwhich prevents using DataRentgen with other OpenLineage integrations (e.g. Flink). Replace it with a small tablejob_typewith just one unique columntype: stringthere all the unique types are stored (in formatINTEGRATION_SMTHorINTEGRATION). ColumnJob.type: textwas converted toJob.type_id: bigint.Also updated field types in
jobTypefacet.processingTypefield is mandatory, and instead of null/None it is passed as stringNONE.jobTypefield is actually optional.Related issue number
Checklist
docs/changelog/next_release/<pull request or issue id>.<change type>.rstfile added describing change(see CONTRIBUTING.rst for details.)