Skip to content

[DOP-25498] Allow to parse unknown RunEvent as Run+Operation#206

Merged
dolfinus merged 1 commit into
developfrom
feature/DOP-25498
Apr 29, 2025
Merged

[DOP-25498] Allow to parse unknown RunEvent as Run+Operation#206
dolfinus merged 1 commit into
developfrom
feature/DOP-25498

Conversation

@dolfinus

@dolfinus dolfinus commented Apr 28, 2025

Copy link
Copy Markdown
Member

Change Summary

If received RunEvent has unknown integration type, and has any input or output, create Run + Operation instead of just Run. Added integration tests, moved some fixtures to dedicated files.

Related issue number

Checklist

  • Commit message and PR title is comprehensive
  • Keep the change as small as possible
  • Unit and integration tests for the changes exist
  • Tests pass on CI and coverage does not decrease
  • Documentation reflects the changes where applicable
  • docs/changelog/next_release/<pull request or issue id>.<change type>.rst file added describing change
    (see CONTRIBUTING.rst for details.)
  • My PR is ready to review.

@dolfinus dolfinus self-assigned this Apr 28, 2025
@dolfinus dolfinus added the ci:skip-changelog Add this label to skip changelog file check label Apr 28, 2025
@codecov

codecov Bot commented Apr 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 91.93%. Comparing base (559d78b) to head (c544b9e).
⚠️ Report is 119 commits behind head on develop.

Files with missing lines Patch % Lines
...ata_rentgen/consumer/extractors/batch_extractor.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #206      +/-   ##
===========================================
+ Coverage    91.83%   91.93%   +0.10%     
===========================================
  Files          205      205              
  Lines         5092     5095       +3     
  Branches       364      365       +1     
===========================================
+ Hits          4676     4684       +8     
+ Misses         336      333       -3     
+ Partials        80       78       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dolfinus dolfinus requested a review from TiGrib April 28, 2025 13:56
@dolfinus dolfinus marked this pull request as ready for review April 28, 2025 13:56
@dolfinus dolfinus merged commit 91d401e into develop Apr 29, 2025
@dolfinus dolfinus deleted the feature/DOP-25498 branch April 29, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:skip-changelog Add this label to skip changelog file check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants