[DOP-25451] Use PUT /v1/queues/:id instead of PATCH

Author: dolfinus

docs/changelog/0.2.2.rst

@@ -1,8 +1,21 @@
 0.2.2 (2025-04-11)
 ==================
 
+Breaking
+--------
+
+- Use ``PUT /v1/queues/:id`` instead of ``PATCH /v1/queues/:id``.
+- Minimal queue name is 3 symbols instead of 1.
+
+Improvements
+------------
+
+- Now queue name can include spaces.
+- Queue slug is always lowercase. Spaces, hyphens and underscores are replaced with ``-`` symbol.
+
 Bug fixes
 ---------
 
-- Call ``kinit`` before starting Spark session conecting to ``Hive`` cluster.
-- Fix ``HDFS`` connection was trying to use anonymous auth instead of user/password.
+- Call ``kinit`` before starting Spark session conecting to ``Hive`` cluster. (:issue:`225`)
+- Fix ``HDFS`` connection was trying to use anonymous auth instead of user/password. (:issue:`225`)
+- Fix updating queue ignored name and didn't reset description.

syncmaster/db/repositories/queue.py

@@ -73,10 +73,10 @@ async def update(
         queue_data: UpdateQueueSchema,
     ) -> Queue:
         try:
-            queue = await self.read_by_id(queue_id=queue_id)
             return await self._update(
                 Queue.id == queue_id,
-                description=queue_data.description or queue.description,
+                name=queue_data.name,
+                description=queue_data.description,
             )
         except IntegrityError as e:
             self._raise_error(e)

syncmaster/schemas/v1/queue.py

@@ -1,22 +1,33 @@
 # SPDX-FileCopyrightText: 2023-2024 MTS PJSC
 # SPDX-License-Identifier: Apache-2.0
-from pydantic import BaseModel, ConfigDict, Field, computed_field, constr
+import re
+from typing import Annotated
+
+from pydantic import BaseModel, ConfigDict, Field, StringConstraints, computed_field
 
 from syncmaster.schemas.v1.page import PageSchema
 
+ALLOWED_PATTERN = re.compile(r"^[-_ a-zA-Z0-9]+$")
+RESTRICTED_PATTERN = re.compile(r"[^\w\d]+")
+
+QueueName = Annotated[
+    str,
+    StringConstraints(min_length=3, max_length=128, pattern=ALLOWED_PATTERN),  # noqa: WPS432
+]
+
 
 class CreateQueueSchema(BaseModel):
-    name: constr(max_length=128, pattern=r"^[-_a-zA-Z0-9]+$") = Field(  # noqa: F722, WPS432
-        ...,
+    name: QueueName = Field(
         description="Queue name that allows letters, numbers, dashes, and underscores",
     )
-    group_id: int = Field(..., description="Queue owner group id")
+    group_id: int = Field(description="Queue owner group id")
     description: str = Field(default="", description="Additional description")
 
     @computed_field
     @property
     def slug(self) -> str:
-        return f"{self.group_id}-{self.name}"
+        short_name = RESTRICTED_PATTERN.sub("_", self.name.lower())
+        return f"{self.group_id}-{short_name}"
 
 
 class ReadQueueSchema(BaseModel):
@@ -34,4 +45,5 @@ class QueuePageSchema(PageSchema):
 
 
 class UpdateQueueSchema(BaseModel):
-    description: str | None = None
+    name: QueueName
+    description: str = ""

syncmaster/server/api/v1/queue.py

@@ -94,7 +94,7 @@ async def create_queue(
     return ReadQueueSchema.model_validate(queue, from_attributes=True)
 
 
-@router.patch("/queues/{queue_id}", description="Updating queue information")
+@router.put("/queues/{queue_id}", description="Updating queue information")
 async def update_queue(
     queue_id: int,
     queue_data: UpdateQueueSchema,