always check consistency even on Release

nschimme · nschimme · commit 13b9ceefe80a · 2025-05-15T12:33:00.000-05:00
diff --git a/src/map/World.cpp b/src/map/World.cpp
@@ -1213,9 +1213,10 @@ World World::init(ProgressCounter &counter, const std::vector<ExternalRawRoom> &
         counter.step();
     }
 
-    if constexpr ((IS_DEBUG_BUILD)) {
+    // if constexpr ((IS_DEBUG_BUILD))
+    {
         DECL_TIMER(t5, "check-consistency");
-        counter.setNewTask(ProgressMsg{"checking map consistency [debug]"}, 1);
+        counter.setNewTask(ProgressMsg{"checking map consistency" /*" [debug]"*/}, 1);
         w.checkConsistency(counter);
         counter.step();
     }
@@ -1917,9 +1918,7 @@ void World::post_change_updates(ProgressCounter &pc)
     if (needsBoundsUpdate()) {
         updateBounds(pc);
     }
-    if constexpr (IS_DEBUG_BUILD) {
-        checkConsistency(pc);
-    }
+    checkConsistency(pc);
 }
 
 void World::applyOne(ProgressCounter &pc, const Change &change)

Original file line number	Diff line number	Diff line change
`@@ -1213,9 +1213,10 @@ World World::init(ProgressCounter &counter, const std::vector<ExternalRawRoom> &`
`1213`	`1213`	`counter.step();`
`1214`	`1214`	`}`
`1215`	`1215`
`1216`		`- if constexpr ((IS_DEBUG_BUILD)) {`
	`1216`	`+ // if constexpr ((IS_DEBUG_BUILD))`
	`1217`	`+ {`
`1217`	`1218`	`DECL_TIMER(t5, "check-consistency");`
`1218`		`- counter.setNewTask(ProgressMsg{"checking map consistency [debug]"}, 1);`
	`1219`	`+ counter.setNewTask(ProgressMsg{"checking map consistency" /" [debug]"/}, 1);`
`1219`	`1220`	`w.checkConsistency(counter);`
`1220`	`1221`	`counter.step();`
`1221`	`1222`	`}`
`@@ -1917,9 +1918,7 @@ void World::post_change_updates(ProgressCounter &pc)`
`1917`	`1918`	`if (needsBoundsUpdate()) {`
`1918`	`1919`	`updateBounds(pc);`
`1919`	`1920`	`}`
`1920`		`- if constexpr (IS_DEBUG_BUILD) {`
`1921`		`- checkConsistency(pc);`
`1922`		`- }`
	`1921`	`+ checkConsistency(pc);`
`1923`	`1922`	`}`
`1924`	`1923`
`1925`	`1924`	`void World::applyOne(ProgressCounter &pc, const Change &change)`