Make resilient inverter wrapper default: True (#399)

* Initial plan

* Make resilient_wrapper default True for release 0.7.0

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Author: Copilot

config/batcontrol_config_dummy.yaml

@@ -105,7 +105,7 @@ inverter:
                         # Only affects mode 8; ignored in other modes.
   # fronius_inverter_id: '1' # Optional: ID of the inverter in Fronius API (default: '1')
   # fronius_controller_id: '0' # Optional: ID of the controller in Fronius API (default: '0')
-  enable_resilient_wrapper: false # Skip a control cycle on transient inverter outages instead of terminating (default: false)
+  enable_resilient_wrapper: true # Skip a control cycle on transient inverter outages instead of terminating (default: true)
   outage_tolerance_minutes: 24 # Minutes to tolerate inverter outages before terminating (default: 24)
 
 #--------------------------

docs/configuration/inverter-configuration.md

@@ -30,7 +30,7 @@ Why not just let batcontrol crash and rely on the container restart policy? With
 
 Default:
 ```
-enable_resilient_wrapper: false
+enable_resilient_wrapper: true
 ```
 
 ### outage_tolerance_minutes

src/batcontrol/inverter/inverter.py

@@ -106,8 +106,8 @@ def create_inverter(config: dict) -> InverterInterface:
         inverter.inverter_num = Inverter.num_inverters
         Inverter.num_inverters += 1
 
-        # Check if resilient wrapper is enabled (default: False)
-        enable_resilient_wrapper = config.get('enable_resilient_wrapper', False)
+        # Check if resilient wrapper is enabled (default: True)
+        enable_resilient_wrapper = config.get('enable_resilient_wrapper', True)
 
         if not enable_resilient_wrapper:
             logger.info('Resilient wrapper disabled by configuration')

tests/batcontrol/inverter/test_dummy.py

@@ -110,6 +110,19 @@ def test_dummy_energy_calculations(self):
         free_capacity = dummy.get_free_capacity()
         assert free_capacity == 3000  # (95% - 65%) of 10000 Wh
 
+    def test_dummy_factory_with_resilient_wrapper_default(self):
+        """Test that factory returns wrapped inverter by default (enable_resilient_wrapper not set)"""
+        config = {
+            'type': 'dummy',
+            'max_grid_charge_rate': 3000,
+        }
+
+        inverter = Inverter.create_inverter(config)
+        # Default is now True, so factory returns ResilientInverterWrapper
+        assert isinstance(inverter, ResilientInverterWrapper)
+        assert isinstance(inverter.wrapped_inverter, Dummy)
+        assert inverter.max_grid_charge_rate == 3000
+
     def test_dummy_factory_with_resilient_wrapper_disabled(self):
         """Test that factory returns unwrapped inverter when resilient wrapper is disabled"""
         config = {

tests/batcontrol/inverter/test_fronius_modbus_factory.py

@@ -27,6 +27,7 @@ def test_factory_creates_fronius_modbus_inverter_with_expected_defaults(mocker):
         "address": "192.168.1.100",
         "capacity": 10000,
         "max_grid_charge_rate": 5000,
+        "enable_resilient_wrapper": False,
     }
 
     inverter = Inverter.create_inverter(config)
@@ -57,6 +58,7 @@ def test_factory_passes_explicit_fronius_modbus_config_values(mocker):
         "max_soc": 95,
         "max_grid_charge_rate": 6000,
         "revert_seconds": 900,
+        "enable_resilient_wrapper": False,
     }
 
     inverter = Inverter.create_inverter(config)
@@ -82,6 +84,7 @@ def test_factory_accepts_fronius_modbus_type_case_insensitively(mocker):
         "address": "192.168.1.100",
         "capacity": 10000,
         "max_grid_charge_rate": 5000,
+        "enable_resilient_wrapper": False,
     }
 
     inverter = Inverter.create_inverter(config)
@@ -126,6 +129,7 @@ def test_factory_accepts_legacy_max_charge_rate_alias_for_fronius_modbus(mocker)
         "address": "192.168.1.100",
         "capacity": 10000,
         "max_charge_rate": 4200,
+        "enable_resilient_wrapper": False,
     }
 
     inverter = Inverter.create_inverter(config)

tests/batcontrol/inverter/test_inverter_factory.py

@@ -20,6 +20,7 @@ def test_factory_creates_mqtt_inverter():
         "type": "mqtt",
         "capacity": 10000,
         "max_grid_charge_rate": 5000,
+        "enable_resilient_wrapper": False,
     }
 
     inverter = Inverter.create_inverter(config)
@@ -35,6 +36,7 @@ def test_factory_uses_max_charge_rate_alias_for_mqtt():
         "type": "mqtt",
         "capacity": 10000,
         "max_charge_rate": 4200,
+        "enable_resilient_wrapper": False,
     }
 
     inverter = Inverter.create_inverter(config)
@@ -50,6 +52,7 @@ def test_factory_prefers_max_grid_charge_rate_over_alias():
         "capacity": 10000,
         "max_grid_charge_rate": 5000,
         "max_charge_rate": 4200,
+        "enable_resilient_wrapper": False,
     }
 
     inverter = Inverter.create_inverter(config)
@@ -64,6 +67,7 @@ def test_factory_accepts_mqtt_type_case_insensitively():
         "type": "MQTT",
         "capacity": 10000,
         "max_grid_charge_rate": 5000,
+        "enable_resilient_wrapper": False,
     }
 
     inverter = Inverter.create_inverter(config)
@@ -77,6 +81,7 @@ def test_factory_applies_mqtt_defaults():
         "type": "mqtt",
         "capacity": 10000,
         "max_grid_charge_rate": 5000,
+        "enable_resilient_wrapper": False,
     }
 
     inverter = Inverter.create_inverter(config)
@@ -115,6 +120,7 @@ def test_factory_builds_fronius_with_expected_config(mocker):
         "max_pv_charge_rate": 1700,
         "fronius_inverter_id": 3,
         "fronius_controller_id": 4,
+        "enable_resilient_wrapper": False,
     }
 
     inverter = Inverter.create_inverter(config)