little fixes/tuning by guess

Author: marcinn

addons/libmaszyna/e3d/e3d_nodes_instancer.gd

@@ -117,7 +117,7 @@ func _do_add_submodels(
             # Applying transform before adding may cause issues (especially on windows)
             if child is Node3D and submodel.transform:
                 var child_node:Node3D = child as Node3D
-                if child is SpotLight3D:
+                if submodel.submodel_type == E3DSubModel.SUBMODEL_FREE_SPOTLIGHT:
                     # Do not scale SpotLight3D to avoid configuration warnings
                     child_node.position = submodel.transform.origin
                     child_node.basis = submodel.transform.basis.orthonormalized()
@@ -149,7 +149,10 @@ func _create_submodel_instance(target_node: E3DModelInstance, submodel: E3DSubMo
             obj = SpotLight3D.new()
             obj.name = submodel.resource_name
             obj.light_color = submodel.diffuse_color
-            obj.light_energy = submodel.visibility_light
+            obj.light_color.a = 1.0
+            #obj.light_energy = submodel.visibility_light  # ????
+            obj.light_energy = 10.0  # FIXME: guessing
+            obj.light_volumetric_fog_energy = 4.0  # FIXME: guessing
             obj.shadow_enabled = true
             obj.distance_fade_enabled = true
             obj.spot_range = submodel.light_range

demo/demo_3d.tscn

@@ -53,9 +53,9 @@ glow_enabled = true
 fog_enabled = true
 fog_sky_affect = 0.4
 volumetric_fog_enabled = true
-volumetric_fog_density = 0.029
+volumetric_fog_density = 0.01
 volumetric_fog_anisotropy = 0.0
-volumetric_fog_length = 0.4
+volumetric_fog_length = 55.89
 volumetric_fog_detail_spread = 1.0
 volumetric_fog_sky_affect = 0.405
 adjustment_enabled = true
@@ -233,6 +233,8 @@ visible = null
 [node name="MaszynaEnvironmentNode" type="Node" parent="." unique_id=1464463242]
 script = ExtResource("2_py6pt")
 world_environment = NodePath("../WorldEnvironment")
+season = 2
+weather = 0
 sky_texture_offset = Vector2(0.49, 0.005)
 sky_texture_scale = Vector2(0.547, 0.865)
 sky_energy = 0.85
@@ -248,6 +250,7 @@ size = Vector3(5000, 0.1, 5000)
 
 [node name="DirectionalLight3D" type="DirectionalLight3D" parent="." unique_id=786641912]
 transform = Transform3D(-0.846557, 0.01871, 0.531969, 0.393589, 0.694835, 0.601906, -0.358369, 0.718925, -0.595582, 5.83027, -6.14961, 0)
+visible = false
 light_color = Color(0.929688, 0.848771, 0.817108, 1)
 light_energy = 1.12
 light_indirect_energy = 2.0

demo/vehicles/sm42/sm_42.tscn

@@ -39,7 +39,7 @@ lights_state = Dictionary[String, bool]({
 "endsignal13": false,
 "endsignal22": false,
 "endsignal23": false,
-"headlamp11": false,
+"headlamp11": true,
 "headlamp12": true,
 "headlamp13": true,
 "headlamp21": false,